-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Allow adjutment of router replica count #2600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
482bafa
to
ed25de3
Compare
Hi, thank you for your contribution. Do you foresee any component else that needs to do the same? |
Signed-off-by: Viet Nguyen Duc <[email protected]>
I'm not familiar enough with each component to be able to say for sure, but it might not hurt to make each of them configurable. I can run through and change them all if you'd like |
Yeah, go ahead with your changes. I think this is a chance to move all replicas configurable from values |
Signed-off-by: Viet Nguyen Duc <[email protected]>
@joshfng, thank you! I added for the rest and will release a new chart |
User description
Description
This enables HA for the router deployment
Motivation and Context
Allows the charts to be deployed without the router services going offline, breaking any in-flight selenium runs with a http error
Types of changes
PR Type
Enhancement
Description
Added support for configurable router replica count.
Updated
router-deployment.yaml
to use dynamic replica values.Introduced a new
replicas
field invalues.yaml
.Changes walkthrough 📝
router-deployment.yaml
Use dynamic replica count in router deployment
charts/selenium-grid/templates/router-deployment.yaml
.Values.components.router.replicas
for replica configuration.values.yaml
Add replicas configuration in values.yaml
charts/selenium-grid/values.yaml
replicas
field undercomponents.router
.