-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
K8s: Set K8s node IP to all components via env var KUBERNETES_NODE_HOST_IP #2668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ST_IP Signed-off-by: Viet Nguyen Duc <[email protected]>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 76577b7)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
76577b7
to
d515b07
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
d515b07
to
98aa10b
Compare
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #2656
In case your observability collector agents running on the Kubernetes Nodes as Daemonsets, you can to set
tracing.exporterEndpoint
point to IP address for Kubernetes node. For example:In each component deployment, we already exposed the environment variable
KUBERNETES_NODE_HOST_IP
to get the IP address of the Kubernetes node where the component is running. So, you can use environment variable pattern in the value oftracing.exporterEndpoint
as above.Note: If you set value via Helm CLI, ensure to escape the
$
character in the value to prevent it confused with the shell variable. For example:Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Documentation, Tests
Description
Added support for setting Kubernetes Node IP as an environment variable (
KUBERNETES_NODE_HOST_IP
) across all Selenium Grid components.Enabled configuration of OTLP tracing exporter endpoint using the Kubernetes Node IP.
Updated Helm chart documentation to guide users on configuring tracing with Node IP.
Enhanced test scripts to include tracing exporter endpoint configuration.
Changes walkthrough 📝
1 files
Add tracing exporter endpoint configuration in test scripts
7 files
Inject Kubernetes Node IP as environment variable in node template
Add Kubernetes Node IP environment variable to distributor deployment
Add Kubernetes Node IP environment variable to event bus deployment
Add Kubernetes Node IP environment variable to hub deployment
Add Kubernetes Node IP environment variable to router deployment
Add Kubernetes Node IP environment variable to session map deployment
Add Kubernetes Node IP environment variable to session queue
deployment
1 files
Add tracing exporter endpoint to autoscaling test configurations
1 files
Document tracing configuration with Kubernetes Node IP