Fix: Restore a Mistakenly Deleted %s Format Specifier in Template

[KenHuPricer]

User description

Description

This PR addresses a bug in the charts/selenium-grid/templates/_helpers.tpl file, where a %s format specifier was accidentally deleted. This specifier is critical for generating proper NGINX Ingress configurations, specifically for the proxy-ssl-secret key. Without it, the generated paths are incorrect, leading to potential misconfigurations during deployments.

The fix involves reintroducing the %s format specifier in the appropriate location within the template.

Motivation and Context

The missing %s caused the generated configurations for SSL secrets to break, which resulted in NGINX Ingress being unable to properly reference the SSL secrets needed for TLS termination. This PR resolves this issue, enabling the correct generation of paths in the Ingress configuration.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Bug fix

---

Description

• Restores a mistakenly deleted %s format specifier.

• Fixes incorrect NGINX Ingress proxy-ssl-secret configurations.

• Ensures proper SSL secret path generation for deployments.

---

Changes walkthrough 📝

	Relevant files
Bug fix	_helpers.tpl Restore `%s` format specifier in template                                charts/selenium-grid/templates/_helpers.tpl Reintroduced the %s format specifier in proxy-ssl-secret. Fixed path generation for SSL secret references. Ensured compatibility with NGINX Ingress configurations. +1/-1

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[CLAassistant]

All committers have signed the CLA.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ No major issues detected

[qodo-merge-pro]

PR Code Suggestions ✨

No code suggestions found for the PR.

[VietND96]

Good catch! It is impacted while fixing another bug.
But do you think is there any chance that user needs to link another secret not in the same NS with grid? For example user given explicitly namespace/external-secret-name

[VietND96]

I just checked, it probably support in the same NS only. So, this change is enough

[VietND96]

Thank you! The fix in chart 0.41.1

[KenHuPricer]

Thank you too!