-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[🚀 Feature]: Offline Mode in Selenium Manager #11639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I made some comments in the original feature request (#11636). Regarding the proposed environment variable proposed in this issue ( To make it more compliant with the current implementation, maybe we can add a Selenium Manager flag called |
The original reason/request (#11636) was made because we changed the original Grid behavior. We were downloading drivers and making them available by default. The original behavior was to detect the available drivers and build the stereotypes from there. I made a fix in this commit 6cb3e2f Aside of the Grid use case, no one has asked for this feature. So I believe we do not need this right now. |
Hmm, yeah, I guess for bindings we just tell people to specify the location of the driver if you don't want to toggle selenium manager. |
yeah, I'm going to close this as I think what Diego has done is good enough, can create a new issue if someone wants more. |
I'm reopening this one. If we are going to move functionality for checking whether the driver is on PATH from the bindings to SM, we need users to be able to explicitly tell SM to accept what is on the machine without downloading. I think ENV is the right way to do this. |
Now after learning more about the usage, I think what Boni proposed initially is what we need to implement. |
After further discussion, it was decided that the feature should be considered an "offline mode" which means no network calls of any kind, not just downloads. Selenium Manager can look for drivers on PATH or in cache, and log warnings if things don't look correct, but do no remediations |
Done! |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Feature and motivation
This would address issues like #11636 as well as some of the concerns people have raised around changes in perception of security considerations.
I think this should be managed in Rust instead of in each binding and the grid, since there is more functionality the Manager should be doing than just downloads. So that means it needs to be an environment variable.
Usage example
ENV["SELENIUM_MANAGER_DOWNLOADS_DISABLED"] = true
The text was updated successfully, but these errors were encountered: