Skip to content

[🐛 Bug]: Selenium Manager and.NET #12301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
titusfortner opened this issue Jul 2, 2023 · 5 comments
Closed

[🐛 Bug]: Selenium Manager and.NET #12301

titusfortner opened this issue Jul 2, 2023 · 5 comments
Assignees
Labels
C-dotnet .NET Bindings I-defect Something is not working as intended
Milestone

Comments

@titusfortner
Copy link
Member

titusfortner commented Jul 2, 2023

What happened?

Unlike other languages, .NET is doing the first part of the location outside of the "driver finder." So the Driver verification class is not distinguishing between the default behavior and what a user might be passing in.

If the user is passing in something incorrect, we need to raise an exception for that, rather than try to remediate it the way we would if the default isn't working.

Also, unlike other languages .NET has you specify the directory the driver is in, not the full path to the file itself. We may want to be more accommodating of this possibility by checking if it is a full path or if it is the directory.

How can we reproduce the issue?

var service = ChromeDriverService.CreateDefaultService();
service.DriverServicePath = "definitely/not/a/driver/path.exe";

driver = new ChromeDriver(service);

Relevant log output

oh .NET and logging...

Operating System

any

Selenium version

trunk

What are the browser(s) and version(s) where you see this issue?

any

What are the browser driver(s) and version(s) where you see this issue?

any

Are you using Selenium Grid?

no

@titusfortner titusfortner added C-dotnet .NET Bindings I-defect Something is not working as intended labels Jul 2, 2023
@titusfortner titusfortner added this to the 4.11 milestone Jul 3, 2023
@NCLnclNCL
Copy link

use this will working ChromeDriverService service = ChromeDriverService.CreateDefaultService(@"D:\chromedriver new", "chromedriver.exe");

@titusfortner
Copy link
Member Author

Yes, but right now if the driver doesn't exist in that directory, Selenium will ignore it and use the Manager to download a new one, when it should error instead.

@NCLnclNCL
Copy link

Yes, but right now if the driver doesn't exist in that directory, Selenium will ignore it and use the Manager to download a new one, when it should error instead.

Yes it is bad

@titusfortner
Copy link
Member Author

Fixed with referenced PRs

Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-dotnet .NET Bindings I-defect Something is not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants