Skip to content

[dotnet] Use Selenium Manager to locate drivers on PATH #12344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

titusfortner
Copy link
Member

@titusfortner titusfortner commented Jul 12, 2023

Dependencies

Don't evaluate this PR until the following have been merged:
* #12342
* #12343
* Also I think this breaks Appium so I need to redo it without changing all the method parameters.

Description

  • Driver Finder is only used in Default service constructor
  • Removed DriverFinder usage in Driver constructor; it only needs to happen when a default Service class is created because that is the only place a user does not have to specify it, and we do not want to remediate.
  • No longer need special Safari Technology Preview handling in Service; SM handles it based on Options
  • I made the driver url parameter optional because we no longer use it, and deleted those constants
  • Allows user to pass full path to driver in the Service class constructor to match other bindings; should reduce the number of backwards compatibility issues (see [🐛 Bug]: Selenium Manager and.NET #12301)

Motivation and Context

Considerations

This is not backwards compatible from the standpoint that if a user started the service with a random path and it wasn't valid, the code would ignore it and look on PATH or use Selenium Manager. This was a bug (#12301)

@titusfortner titusfortner marked this pull request as ready for review July 12, 2023 22:15
@diemol
Copy link
Member

diemol commented Jul 13, 2023

Do we need to fix the Firefox tests before merging this? Seems Chrome usually passes after a retry.

@titusfortner
Copy link
Member Author

The issue is on trunk as well. Somehow we're losing the geckodriver connection and I don't know why. It passes locally, and usually passes on retry.

@diemol
Copy link
Member

diemol commented Jul 13, 2023

Yes, I was running them locally and they all pass. Strange.

@diemol diemol merged commit 6a48692 into trunk Jul 13, 2023
@diemol diemol deleted the net_path branch July 13, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants