-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🚀 Feature]: use lowercase header names #12697
Comments
@joerg1985, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Makes sense to me. |
assign me |
We don't assign specific issues, but if you make a PR we'll happily review it. Thanks. |
@diemol Is this still a issue? Can I take it? |
@joerg1985 is this still pending? |
@diemol yes this is still open, as it is in milestone selenium 5.0. |
@diemol @titusfortner What should we do with the HttpMessageTest class after the changes? |
This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs. |
Feature and motivation
I would suggest to convert all header names to lowercase in the
HttpMessage
.It might be helpful in the future to have only lower case header names.
The header names should be in general treated case-insensitive, but there might be code somewhere not aware of this, so i would see this in Selenium 5.
Usage example
There is currently a hidden issue due to the case-sensitive map used in the HttpMessage.
The order of headers set depends currently on the map implementation and not on the order of adding them, this can be observed here:
selenium/java/test/org/openqa/selenium/remote/http/HttpMessageTest.java
Lines 53 to 57 in 938058d
message.getHeader("Content-Length")
should actually return"1024"
The text was updated successfully, but these errors were encountered: