Skip to content

[🐛 Bug]: Selenium Manager unable to lookup Edge - Error parsing JSON #14851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliottj opened this issue Dec 4, 2024 · 18 comments · Fixed by #14859
Closed

[🐛 Bug]: Selenium Manager unable to lookup Edge - Error parsing JSON #14851

elliottj opened this issue Dec 4, 2024 · 18 comments · Fixed by #14859
Labels
A-needs-triaging A Selenium member will evaluate this soon! C-rust Rust code is mostly Selenium Manager I-defect Something is not working as intended

Comments

@elliottj
Copy link

elliottj commented Dec 4, 2024

What happened?

Running Selenium Manager Windows 0.4.27 command line to pull any Edge version shows:

C:\AFT>selenium-manager-windows.exe --version
selenium-manager 0.4.27

C:\AFT>selenium-manager-windows.exe --browser edge --browser-version stable --trace --force-browser-download
[2024-12-04T09:28:52.541Z TRACE] Reading metadata from C:\Users\aftadmin\.cache\selenium\se-metadata.json
[2024-12-04T09:28:52.544Z TRACE] Metadata file does not exist. Creating a new one
[2024-12-04T09:28:52.545Z DEBUG] Sending stats to Plausible: Props { browser: "edge", browser_version: "stable", os: "windows", arch: "amd64", lang: "", selenium_version: "4.27" }
[2024-12-04T09:28:52.545Z TRACE] Writing metadata to C:\Users\aftadmin\.cache\selenium\se-metadata.json
[2024-12-04T09:28:52.546Z TRACE] Checking msedgedriver in PATH
[2024-12-04T09:28:52.573Z DEBUG] msedgedriver not found in PATH
[2024-12-04T09:28:52.574Z TRACE] Reading metadata from C:\Users\aftadmin\.cache\selenium\se-metadata.json
[2024-12-04T09:28:52.575Z DEBUG] Checking edge releases on https://edgeupdates.microsoft.com/api/products/
[2024-12-04T09:28:52.623Z ERROR] Error parsing JSON from URL https://edgeupdates.microsoft.com/api/products/ missing field `ArtifactName` at line 1 column 517

When I look at https://edgeupdates.microsoft.com/api/products/ the json has an "artifactName" (lower case a at start), and only for the browser, not the webdriver - I'm not sure of the format SM expects?
image

How can we reproduce the issue?

See above.

Relevant log output

See above.

Operating System

Windows 10

Selenium version

selenium-manager 0.4.27

What are the browser(s) and version(s) where you see this issue?

Edge all versions

What are the browser driver(s) and version(s) where you see this issue?

Edge all versions

Are you using Selenium Grid?

n/a

@elliottj elliottj added I-defect Something is not working as intended A-needs-triaging A Selenium member will evaluate this soon! labels Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

@elliottj, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@elliottj elliottj changed the title [🐛 Bug]: Selenium Manager unable pull Edge [🐛 Bug]: Selenium Manager unable to lookup Edge - Error parsing JSON Dec 4, 2024
@JTarlin
Copy link

JTarlin commented Dec 4, 2024

Also experiencing the same issue as Elliot, in my case using Selenium Webdriver 4.27.0 and Edge 130.

@Fman77
Copy link

Fman77 commented Dec 5, 2024

Seeing the same issue, using selenium-manager 0.4.23 and Edge 131

@pujagani pujagani added the C-rust Rust code is mostly Selenium Manager label Dec 5, 2024
@elliottj
Copy link
Author

elliottj commented Dec 5, 2024

I think it'll impact all versions of Selenium Manager if it's an unexpected change in the format of the data returned by https://edgeupdates.microsoft.com/api/products/ (ArtifactName vs artifactName)

@Delta456
Copy link
Member

Delta456 commented Dec 5, 2024

Can this issue be reproduced on other Operating Systems?

@elliottj
Copy link
Author

elliottj commented Dec 5, 2024

Yes same on RHEL - given it's a change in the response from API call it will impact all OS and versions.

./selenium-manager-linux --browser edge --browser-version stable --debug
[2024-12-05T10:07:37.712Z DEBUG] Sending stats to Plausible: Props { browser: "edge", browser_version: "stable", os: "linux", arch: "x86_64", lang: "", selenium_version: "4.27" }
[2024-12-05T10:07:37.721Z DEBUG] msedgedriver not found in PATH
[2024-12-05T10:07:37.722Z DEBUG] edge not found in PATH
[2024-12-05T10:07:37.722Z DEBUG] edge stable not found in the system
[2024-12-05T10:07:37.723Z DEBUG] Checking edge releases on https://edgeupdates.microsoft.com/api/products/
[2024-12-05T10:07:37.876Z ERROR] Error parsing JSON from URL https://edgeupdates.microsoft.com/api/products/ missing field `ArtifactName` at line 1 column 517

@Delta456
Copy link
Member

Delta456 commented Dec 5, 2024

I will try to reproduce and work on fixing this.

@Delta456
Copy link
Member

Delta456 commented Dec 5, 2024

I have a fix. A PR will be open soon.

bonigarcia added a commit that referenced this issue Dec 11, 2024
* [selenium manager]: fix edge artifact deserialisation

* add alias attr to all edge structs

* add newline

---------

Co-authored-by: Boni García <[email protected]>
@ganeshprabu1997
Copy link

ganeshprabu1997 commented Dec 13, 2024

When can we expect this fix in Live @bonigarcia ?

@bonigarcia
Copy link
Member

It will be shipped in the next Selenium release (4.28). But if you need it now, you can download the new Selenium Manager binary from here: https://github.com/SeleniumHQ/selenium/actions/runs/12316815660

@ganeshprabu1997
Copy link

It will be shipped in the next Selenium release (4.28). But if you need it now, you can download the new Selenium Manager binary from here: https://github.com/SeleniumHQ/selenium/actions/runs/12316815660

Thanks @bonigarcia

@elliottj
Copy link
Author

elliottj commented Dec 19, 2024

@bonigarcia Thanks for fix, any idea when the next release will be please?

@diemol
Copy link
Member

diemol commented Dec 19, 2024

Around the second week of January.

@jvanderwoude80
Copy link

The artifacts are expired, any other location available to get the latest selenium manager? Thanks!

@Delta456
Copy link
Member

Delta456 commented Jan 3, 2025

The artifacts are expired, any other location available to get the latest selenium manager? Thanks!

Try this https://github.com/SeleniumHQ/selenium/actions/runs/12538948126

@jvanderwoude80
Copy link

The artifacts are expired, any other location available to get the latest selenium manager? Thanks!

Try this https://github.com/SeleniumHQ/selenium/actions/runs/12538948126

Thanks! Downloading Edge now works.

@saiganesh98
Copy link

saiganesh98 commented Jan 22, 2025

FYI, the older field names are now appearing in the API response, and downloading Edge seems to be working as expected. However, it’s unclear when this change was implemented by the Microsoft team. Users do not need to upgrade the Selenium version immediately.

Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-needs-triaging A Selenium member will evaluate this soon! C-rust Rust code is mostly Selenium Manager I-defect Something is not working as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants