Skip to content

[🐛 Bug]: get_downloadable_files() returns a list of str, not a dict #15288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsa34 opened this issue Feb 14, 2025 · 4 comments · Fixed by #15293
Closed

[🐛 Bug]: get_downloadable_files() returns a list of str, not a dict #15288

jsa34 opened this issue Feb 14, 2025 · 4 comments · Fixed by #15293
Assignees
Labels
A-needs-triaging A Selenium member will evaluate this soon! B-docs API Docs; see other repo for website documentation C-java Java Bindings C-py Python Bindings

Comments

@jsa34
Copy link

jsa34 commented Feb 14, 2025

What happened?

In the Python bindings, when using the method get_downloadable_files(), the return type is stated as "dict" and the documentation appears to suggest it should be a dict, with the file names as keys and the paths as values. In reality, it just seems to return a list of files names. I'm not sure if the implementation or the docstring and return type are wrong.

How can we reproduce the issue?

Use the method `get_downloadable_files()`

Relevant log output

None.

Operating System

N/A

Selenium version

4.28.1

What are the browser(s) and version(s) where you see this issue?

N/A

What are the browser driver(s) and version(s) where you see this issue?

N/A

Are you using Selenium Grid?

No response

@jsa34 jsa34 added I-defect Something is not working as intended A-needs-triaging A Selenium member will evaluate this soon! labels Feb 14, 2025
Copy link

@jsa34, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@Delta456
Copy link
Member

Yes, the return type needs to be a list. Thanks for making the issue.

I will work on this.

@Delta456 Delta456 self-assigned this Feb 14, 2025
@Delta456 Delta456 added C-py Python Bindings documentation and removed I-defect Something is not working as intended labels Feb 14, 2025
@jsa34
Copy link
Author

jsa34 commented Feb 14, 2025

It looks like the other Lang bindings could do with updating, too: I checked Java and the return type is List of Strings, but the docstring infers it should return a map.

Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
@titusfortner titusfortner added B-docs API Docs; see other repo for website documentation and removed documentation labels Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-needs-triaging A Selenium member will evaluate this soon! B-docs API Docs; see other repo for website documentation C-java Java Bindings C-py Python Bindings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants