-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java]: fix return type and docstring for getDownloadableFiles
#15293
[java]: fix return type and docstring for getDownloadableFiles
#15293
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, implementation returns as List<String>
. So, updating docs to be aligned is fine, no regression break.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Fixes #15288
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Fixed the return type of
getDownloadableFiles
method toList<String>
.Updated the method's JavaDoc to reflect the corrected return type.
Added a unit test to verify the return type and behavior of
getDownloadableFiles
.Ensured proper formatting by running the formatting script.
Changes walkthrough 📝
RemoteWebDriver.java
Corrected JavaDoc for `getDownloadableFiles` method
java/src/org/openqa/selenium/remote/RemoteWebDriver.java
getDownloadableFiles
method to correct thedescription.
Map
toList
.RemoteWebDriverUnitTest.java
Added unit test for `getDownloadableFiles` method
java/test/org/openqa/selenium/remote/RemoteWebDriverUnitTest.java
getDownloadableFiles
method.