[🚀 Feature]: [dotnet] [bidi] Don't use nested DTO types (!)

[nvborisenko]

Feature and motivation

This is a continuation of #14530 point 1: "Discriminated unions". I proposed and implemented Local.Css nested type instead of CssLocator type. My last comment in that already resolved issue was:

I feel new CssLocator("div"); is better, we can make it before v5 if we have strong arguments (types discovery is a good argument).

I was wrong, and now I come with arguments. Actually only one argument. Nested type reserves its name in the parent. Which means we cannot add more members with the same name.

Use cases:

• Static factory: when Selenium Team will have capacity to add more useful methods like Locator.Css("div") it will not be possible, because Css is already defined in Locator class.
• Static singleton: In Script module we have LocalValue.Null class. This is great candidate to be singleton. But we cannot do it because Null name is already reserved by nested type.

Usage example

Before:

new Locator.Css("div");

After:

new CssLocator("div");

And all types with similar pattern.

[github-actions]

@nvborisenko, thank you for creating this issue. We will troubleshoot it as soon as we can.

---

Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

[nvborisenko]

Everything is addressed? We should double check.

[nvborisenko]

Seems abstract records are addressed. Now it is time to analyze how we use other nested types.

[nvborisenko]

• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.BrowsingContext.AccessibilityLocator.AccessibilityLocatorValue.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.BrowsingContext.CaptureScreenshotOptions.ScreenshotOrigin.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.BrowsingContext.ContextLocator.ContextLocatorValue.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.BrowsingContext.InnerTextLocator.Match.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.Network.AuthCredentials.Basic.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.Script.ChannelLocalValue.ChannelProperties.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.Script.EvaluateResult.Exception.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.Script.EvaluateResult.Success.html
• https://www.selenium.dev/selenium/docs/api/dotnet/webdriver/OpenQA.Selenium.BiDi.Modules.Script.WindowProxyRemoteValue.Properties.html

[nvborisenko]

@RenderMichael I have prepared PRs, all of them are simple. #15493 requires attention.

[RenderMichael]

Simple changes all around, all approved.