[dotnet] [bidi] Decouple ScreenshotOrigin in BrowsingContext module #15488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Motivation and Context
Contributes to #15407
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Decoupled
ScreenshotOrigin
fromCaptureScreenshotOptions
to avoid nested DTO types.Updated
CaptureScreenshotCommandParameters
to use the newScreenshotOrigin
enum.Refactored related test cases to align with the new structure.
Improved code clarity and future extensibility by removing nested types.
Changes walkthrough 📝
CaptureScreenshotCommand.cs
Decoupled `ScreenshotOrigin` from `CaptureScreenshotOptions`
dotnet/src/webdriver/BiDi/Modules/BrowsingContext/CaptureScreenshotCommand.cs
CaptureScreenshotOptions.ScreenshotOrigin
with astandalone
ScreenshotOrigin
enum.CaptureScreenshotCommandParameters
to use the standaloneScreenshotOrigin
.BrowsingContextTest.cs
Updated tests for refactored `ScreenshotOrigin` usage
dotnet/test/common/BiDi/BrowsingContext/BrowsingContextTest.cs
ScreenshotOrigin
enum.CaptureScreenshotCommandParameters
.