Skip to content

[py] updated documentation links. #12326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

sandeepsuryaprasad
Copy link
Contributor

@sandeepsuryaprasad sandeepsuryaprasad commented Jul 9, 2023

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Documentation links updated in firefox/service.py, ie/service.py, safari/service.py, remote/command.py, remote/errorhandler.py

Motivation and Context

Updated documentation links.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner
Copy link
Member

Hmm, we should be linking all driver error messages to the applicable troubleshooting/errors page, I thought we'd done this already?

@sandeepsuryaprasad
Copy link
Contributor Author

Hmm, we should be linking all driver error messages to the applicable troubleshooting/errors page, I thought we'd done this already?

I added w3c link on errors in errorhandler.py

@titusfortner
Copy link
Member

  • Most of the code comment references to JSON Wire Protocol are incorrect because the code is actually using w3c, so many of these need to be updated.
  • We shouldn't need to reference driver download locations anywhere in the code because Selenium now manages driver downloads.
  • We want to get rid of start_error_message here, the NoSuchDriverException contains all the information that is needed. You can see that if there were no driver, the error would happen in the first line, where the start error messages would only get called in the second line - https://github.com/SeleniumHQ/selenium/blob/selenium-4.10.0/py/selenium/webdriver/firefox/webdriver.py#L60-L61

@AutomatedTester AutomatedTester merged commit 067f10a into SeleniumHQ:trunk Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants