Skip to content

[py] use Selenium Manager to locate drivers on PATH #12356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2023
Merged

[py] use Selenium Manager to locate drivers on PATH #12356

merged 2 commits into from
Jul 13, 2023

Conversation

titusfortner
Copy link
Member

Description

  • No longer passing around the driver name
  • Default executable string is None
  • Calls DriverFinder to set path before starting service
  • DriverFinder now only sets the path if it is None

Motivation and Context

Python implementation of #11356

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.06 ⚠️

Comparison is base (3fbd0e5) 57.34% compared to head (364ef01) 57.28%.

❗ Current head 364ef01 differs from pull request most recent head 85ed311. Consider uploading reports for the commit 85ed311 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12356      +/-   ##
==========================================
- Coverage   57.34%   57.28%   -0.06%     
==========================================
  Files          86       86              
  Lines        5352     5333      -19     
  Branches      193      193              
==========================================
- Hits         3069     3055      -14     
+ Misses       2090     2085       -5     
  Partials      193      193              
Impacted Files Coverage Δ
py/selenium/webdriver/common/driver_finder.py 88.23% <50.00%> (-11.77%) ⬇️
py/selenium/webdriver/firefox/webdriver.py 64.47% <60.00%> (+0.83%) ⬆️
py/selenium/webdriver/safari/webdriver.py 50.00% <66.66%> (+2.63%) ⬆️
py/selenium/webdriver/ie/webdriver.py 86.95% <77.77%> (+2.34%) ⬆️
py/selenium/webdriver/edge/webdriver.py 82.35% <80.00%> (+2.35%) ⬆️
py/selenium/webdriver/chrome/service.py 78.94% <100.00%> (-6.06%) ⬇️
py/selenium/webdriver/chrome/webdriver.py 94.11% <100.00%> (-0.89%) ⬇️
py/selenium/webdriver/chromium/service.py 90.62% <100.00%> (+0.30%) ⬆️
py/selenium/webdriver/chromium/webdriver.py 46.15% <100.00%> (+1.05%) ⬆️
py/selenium/webdriver/common/service.py 88.52% <100.00%> (+0.09%) ⬆️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@titusfortner titusfortner force-pushed the py_path branch 3 times, most recently from d1033f4 to 492b4cb Compare July 12, 2023 21:26
@diemol diemol merged commit 6176d7e into trunk Jul 13, 2023
@diemol diemol deleted the py_path branch July 13, 2023 09:10
noneofyourbusiness1415252 added a commit to noneofyourbusiness1415252/selenium that referenced this pull request Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-py Python Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants