[py] implement file downloads #13023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13023 +/- ##
==========================================
+ Coverage 56.49% 56.54% +0.04%
==========================================
Files 86 86
Lines 5255 5281 +26
Branches 187 192 +5
==========================================
+ Hits 2969 2986 +17
- Misses 2099 2103 +4
- Partials 187 192 +5
☔ View full report in Codecov by Sentry. |
titusfortner
force-pushed
the
py_dl_files
branch
4 times, most recently
from
44532ab to
5b68c94
Compare
titusfortner
force-pushed
the
py_dl_files
branch
from
cb4269d to
4777844
Compare
|
@AutomatedTester / @symonk I tried to add testing in the remote directory, but for some reason it wasn't recognizing the driver argument from the bazel file. /shrug |
titusfortner
force-pushed
the
py_dl_files
branch
4 times, most recently
from
4ea7207 to
4b1b35c
Compare
bazel isn't setting a driver for remote-test when running tests in remote directory
titusfortner
force-pushed
the
py_dl_files
branch
from
4b1b35c to
1aea076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
The tests work when I run it locally against a grid I've started; I can't seem to get the remote tests to work with bazel locally, so it's in draft until I see if they pass on the CI. I can't figure out how to get the
test/selenium/webdriver/remote/**/*.pytests to pass in the--driver. What's there "should" work. So I skipping them. But they work against 4.14.1 grid.Description
get_downloadable_files(),download_file()anddelete_downloadable_files()options.enable_downloads = Truemoz:firefoxOptionsbecause of [grid] fix bug in downloading files by ensuring browser vendor option… #13024Motivation and Context
Implements #11657