Skip to content

[rust] Panic if JSON output is used but no entries are collected #13101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR includes a panic call when JSON output is used (e.g., by the bindings) but no entries are collected by SM.

Motivation and Context

In theory, this panic will never be called. But if it happens, it will allow to discover that problems like #13091 are caused in the Rust side.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added the C-rust Rust code is mostly Selenium Manager label Nov 6, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aaec17e) 57.70% compared to head (d1d7382) 57.70%.
Report is 2 commits behind head on trunk.

❗ Current head d1d7382 differs from pull request most recent head a62eda7. Consider uploading reports for the commit a62eda7 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13101   +/-   ##
=======================================
  Coverage   57.70%   57.70%           
=======================================
  Files          86       86           
  Lines        5289     5289           
  Branches      208      208           
=======================================
  Hits         3052     3052           
  Misses       2029     2029           
  Partials      208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-rust Rust code is mostly Selenium Manager
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants