Skip to content

[rust] Fix webview2 support when browser path is set #13204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

bonigarcia
Copy link
Member

Description

This PR fixes the support for Edge's WebView2 in Selenium Manager when browser path is set.

Motivation and Context

Bug reported in #12738.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dde3eed) 57.53% compared to head (764d504) 57.53%.

❗ Current head 764d504 differs from pull request most recent head ad766dd. Consider uploading reports for the commit ad766dd to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13204   +/-   ##
=======================================
  Coverage   57.53%   57.53%           
=======================================
  Files          86       86           
  Lines        5310     5310           
  Branches      221      221           
=======================================
  Hits         3055     3055           
  Misses       2034     2034           
  Partials      221      221           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@titusfortner titusfortner merged commit c806757 into trunk Nov 27, 2023
@titusfortner titusfortner deleted the sm_webview_fix branch November 27, 2023 12:52
LogicOscar pushed a commit to LogicOscar/selenium that referenced this pull request Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-rust Rust code is mostly Selenium Manager
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants