-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Fix "Get Text" to retrieve the correct value for ShadowRoot using slot. #13218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Get Text" to retrieve the correct value for ShadowRoot using slot. #13218
Conversation
@diemol shouldn't this PR have kicked off the RBE job? Should we have changes in atoms directory run all the other tests as well? (Also, should we implement a way to run specific CI jobs on a PR based on specific words in a comment?) |
808d4d9
to
caaa83f
Compare
@titusfortner I do not know. I have not even tried the RBE build. @shs96c should know. |
I'm asking about the github CI starting the build in the first place, and thinking about whether we need to update the logic. |
@titusfortner any chance that you can trigger the workflows? Or should it wait for your investigation and the bot will do it afterward? |
running; I never see that it needs to be done when I check from my phone |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13218 +/- ##
=======================================
Coverage 58.07% 58.07%
=======================================
Files 88 88
Lines 5340 5340
Branches 224 224
=======================================
Hits 3101 3101
Misses 2015 2015
Partials 224 224 ☔ View full report in Codecov by Sentry. |
caaa83f
to
b0ce5bc
Compare
@titusfortner or @diemol, it seems the tests were running fine and test failures existed in other areas. I've now rebased my PR to current trunk, but it requires again someone to manually approve the workflows. :/ Maybe you could help? |
@AutomatedTester or @shs96c could one of you please review? Or if not whom can I ask? Thanks! |
Thank you @titusfortner! |
FYI I'm going to update the Selenium atom reference in WebDriver classic on w3c/webdriver#1783 |
Fixes #13206
Description
As discussed on issue #13206 the "Get Text" atom currently fails to retrieve the correct text for ShadowRoot elements using
<slot>
.Motivation and Context
This currently blocks WebDriver implementations using the Get Text atom to correctly retrieve the visible text of such an element.
Types of changes
Checklist