Skip to content

Fix "Get Text" to retrieve the correct value for ShadowRoot using slot. #13218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2024

Conversation

whimboo
Copy link
Contributor

@whimboo whimboo commented Nov 29, 2023

Fixes #13206

Description

As discussed on issue #13206 the "Get Text" atom currently fails to retrieve the correct text for ShadowRoot elements using <slot>.

Motivation and Context

This currently blocks WebDriver implementations using the Get Text atom to correctly retrieve the visible text of such an element.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@titusfortner
Copy link
Member

@diemol shouldn't this PR have kicked off the RBE job? Should we have changes in atoms directory run all the other tests as well? (Also, should we implement a way to run specific CI jobs on a PR based on specific words in a comment?)

@whimboo whimboo force-pushed the atom_get_text_empty_slot branch from 808d4d9 to caaa83f Compare January 2, 2024 09:05
@diemol
Copy link
Member

diemol commented Jan 5, 2024

@titusfortner I do not know. I have not even tried the RBE build. @shs96c should know.

@titusfortner
Copy link
Member

I'm asking about the github CI starting the build in the first place, and thinking about whether we need to update the logic.
I was in this code yesterday for other reasons, I'll take a look today.

@whimboo
Copy link
Contributor Author

whimboo commented Jan 5, 2024

@titusfortner any chance that you can trigger the workflows? Or should it wait for your investigation and the bot will do it afterward?

@titusfortner
Copy link
Member

running; I never see that it needs to be done when I check from my phone ☹️

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0f42c3) 58.07% compared to head (3b72f08) 58.07%.
Report is 1 commits behind head on trunk.

❗ Current head 3b72f08 differs from pull request most recent head b0ce5bc. Consider uploading reports for the commit b0ce5bc to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13218   +/-   ##
=======================================
  Coverage   58.07%   58.07%           
=======================================
  Files          88       88           
  Lines        5340     5340           
  Branches      224      224           
=======================================
  Hits         3101     3101           
  Misses       2015     2015           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whimboo whimboo force-pushed the atom_get_text_empty_slot branch from caaa83f to b0ce5bc Compare January 8, 2024 10:04
@whimboo
Copy link
Contributor Author

whimboo commented Jan 8, 2024

@titusfortner or @diemol, it seems the tests were running fine and test failures existed in other areas. I've now rebased my PR to current trunk, but it requires again someone to manually approve the workflows. :/ Maybe you could help?

@whimboo
Copy link
Contributor Author

whimboo commented Jan 11, 2024

@AutomatedTester or @shs96c could one of you please review? Or if not whom can I ask? Thanks!

@titusfortner titusfortner merged commit 21560a4 into SeleniumHQ:trunk Jan 20, 2024
@whimboo whimboo deleted the atom_get_text_empty_slot branch January 22, 2024 10:10
@whimboo
Copy link
Contributor Author

whimboo commented Jan 22, 2024

Thank you @titusfortner!

@whimboo
Copy link
Contributor Author

whimboo commented Jan 22, 2024

FYI I'm going to update the Selenium atom reference in WebDriver classic on w3c/webdriver#1783

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: "Get Text" atom ignores slot value for web component without custom text
4 participants