Skip to content

[JS] Fixes unzipping files into target location #13388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 3, 2024
Merged

[JS] Fixes unzipping files into target location #13388

merged 4 commits into from
Jan 3, 2024

Conversation

harsha509
Copy link
Member

@harsha509 harsha509 commented Jan 3, 2024

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@harsha509 harsha509 merged commit 66e19ca into SeleniumHQ:js_download Jan 3, 2024
titusfortner added a commit that referenced this pull request Jan 3, 2024
* error if downloads are not enabled

* unzip and download file to provided directory

* getDownloadableFiles returns the names directly

* fix unzipping files into target location (#13388)

---------

Co-authored-by: harsha509 <[email protected]>
Co-authored-by: Sri Harsha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant