Skip to content

java/CookieHandler: escape cookie values when required #14486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 17, 2024
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ private Collection<Cookie> getCookies(HttpRequest request) {
private void addCookie(HttpResponse response, Cookie cook) {
StringBuilder cookie = new StringBuilder();

// TODO: escape string as necessary
String name = cook.getName();
cookie.append(name).append("=").append(cook.getValue()).append("; ");
String name = escapeCookieValue(cook.getName());
String value = escapeCookieValue(cook.getValue());
cookie.append(name).append("=").append(value).append("; ");

append(cookie, cook.getDomain(), str -> "Domain=" + str);
append(cookie, cook.getPath(), str -> "Path=" + str);
Expand Down Expand Up @@ -191,4 +191,45 @@ private Cookie parse(String cookieString) {

return builder.build();
}

private String escapeCookieValue(String value) {
if (value == null || value.isEmpty()) {
return "";
}

StringBuilder cookieValue = new StringBuilder();

for (char c : value.toCharArray()) {
switch (c) {
case '\\':
cookieValue.append("\\\\");
break;
case '"':
cookieValue.append("\\\"");
break;
case ';':
cookieValue.append("\\;");
break;
case ',':
cookieValue.append("\\,");
break;
case '\r':
case '\n':
// Skip carriage return and newline characters
break;
case '<':
cookieValue.append("&lt;");
break;
case '>':
cookieValue.append("&gt;");
break;
case '&':
cookieValue.append("&amp;");
break;
default:
cookieValue.append(c); // Append safe characters as they are
}
}
return cookieValue.toString();
}
}
Loading