Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Ensure Selenium logging options are respected if java logging … #15197

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[java] Ensure Selenium logging options are respected if java logging … #15197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions java/src/org/openqa/selenium/grid/log/LoggingOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,14 @@ public void configureLogging() {
return;
}

// Keep current loggers if they are being manually set
if (LogManager.getLogManager().getProperty("handlers") != null) return;
String configClass = System.getProperty("java.util.logging.config.class");
String configFile = System.getProperty("java.util.logging.config.file");

// Check if the java logging config class or file is set. If so, give that priority.
// Else default to the Selenium logging and respect the Selenium logging options.
if (configClass != null || configFile != null) {
return;
}

// Remove all handlers from existing loggers
LogManager logManager = LogManager.getLogManager();
Expand Down
Loading