-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Annotate nullability on Actions
type
#15208
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
* [dotnet] Annotate nullability on `Actions` type * Add `Keys` nullability
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Annotate nullability on
Actions
typeMotivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Annotated nullability across the
Actions
class and related methods.Added null checks and exception handling for method arguments.
Improved code clarity with nullable reference types and annotations.
Enhanced documentation with detailed exception summaries.
Changes walkthrough 📝
Actions.cs
Nullability annotations and argument validation in `Actions.cs`
dotnet/src/webdriver/Interactions/Actions.cs
#nullable enable
.ArgumentNullException
for method arguments.InputDevice.cs
Add exception handling for `CreatePause` duration
dotnet/src/webdriver/Interactions/InputDevice.cs
CreatePause
.PauseInteraction.cs
Validate duration in `PauseInteraction` constructor
dotnet/src/webdriver/Interactions/PauseInteraction.cs