-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Annotate nullability on DevToolsSession
#15244
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Test failures are unrelated to this PR //java/test/org/openqa/selenium/mobile:NetworkConnectionTest
//java/test/org/openqa/selenium/remote:RemoteWebDriverScreenshotTest
//java/test/org/openqa/selenium/remote:RemoteWebDriverScreenshotTest-firefox-beta
//rb/spec/integration/selenium/webdriver:network-firefox-beta-bidi
//rb/spec/integration/selenium/webdriver:network-firefox-bidi |
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Annotates nullability on
DevToolsSession
and modifies nullability on related types.Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement, Bug fix
Description
Annotated nullability for
DevToolsSession
and related classes.Fixed typos and improved comments/documentation for clarity.
Enhanced error handling and logging in
DevToolsSession
.Refactored code to ensure null safety and modernized syntax.
Changes walkthrough 📝
DevToolsCommandData.cs
Fix typos and improve constructor documentation
dotnet/src/webdriver/DevTools/DevToolsCommandData.cs
DevToolsSession.cs
Annotate nullability and improve error handling
dotnet/src/webdriver/DevTools/DevToolsSession.cs
DevToolsSessionLogMessageEventArgs.cs
Support nullable arguments in constructor
dotnet/src/webdriver/DevTools/DevToolsSessionLogMessageEventArgs.cs
DevToolsVersionInfo.cs
Simplify regex and improve error handling
dotnet/src/webdriver/DevTools/DevToolsVersionInfo.cs
IDevToolsSession.cs
Annotate nullability and fix documentation typos
dotnet/src/webdriver/DevTools/IDevToolsSession.cs