-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[dotnet] Add back in a public parameterless constructor to HttpRequestData
#15258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add back in a public parameterless constructor to HttpRequestData
#15258
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
HttpRequestData
PR Code Suggestions ✨Explore these optional code suggestions:
|
Simplify null check Co-authored-by: Nikolay Borisenko <[email protected]>
…stData` (SeleniumHQ#15258) * [dotnet] Add back in a public parameterless constructor to `HttpRequestData` * Improve nullability * Make RequestId only settable internally * Revert "Make RequestId only settable internally" This reverts commit d0afea9. * Handle nullability, make new constructor internal * Apply suggestions from code review Simplify null check Co-authored-by: Nikolay Borisenko <[email protected]> * Update dotnet/src/webdriver/HttpRequestData.cs --------- Co-authored-by: Nikolay Borisenko <[email protected]>
User description
…stData`
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
Added a public parameterless constructor to
HttpRequestData
.Updated
RequestId
property to allow null values.Changes walkthrough 📝
HttpRequestData.cs
Add parameterless constructor and nullable `RequestId`
dotnet/src/webdriver/HttpRequestData.cs
RequestId
property to nullable type.