[dotnet] Simplify user creation of network types #15267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Simplify user creation of network types. Do not require any constructors.
Motivation and Context
Fix a break I introduced by adding constructors for HTTP networking types. I did not think these types were intended to be created by users; they were.
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Simplified creation of
HttpRequestData
andHttpResponseData
objects by removing constructors.Updated network-related classes to use object initializers for better readability.
Adjusted properties in
HttpRequestData
andHttpResponseData
to allow internal and nullable setters.Added a new test for transforming network responses in
NetworkInterceptionTests
.Changes walkthrough 📝
8 files
Refactored network event handling to use object initializers
Refactored network event handling to use object initializers
Refactored network event handling to use object initializers
Refactored network event handling to use object initializers
Removed constructor and updated properties for flexibility
Removed constructor and updated properties for flexibility
Adjusted `HttpRequestData` usage to use object initializer
Made properties nullable for better flexibility
1 files
Added test for transforming network responses