Skip to content

[java][dotnet][js] Fix failing BiDi related tests #15296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[java][dotnet][js] Fix failing BiDi related tests #15296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6de15
[java][dotnet][js] Fix failing BiDi related tests
pujagani Feb 18, 2025
f6d0e38
[dotnet] Fix tests
pujagani Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dotnet/test/common/BiDi/Script/CallFunctionParameterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public async Task CanCallFunctionWithDeclarationImplicitCast()
[Test]
public async Task CanEvaluateScriptWithUserActivationTrue()
{
await context.Script.EvaluateAsync("window.open();", true, new() { UserActivation = true });
await context.Script.EvaluateAsync("window.open();", true);

var res = await context.Script.CallFunctionAsync<bool>("""
() => navigator.userActivation.isActive && navigator.userActivation.hasBeenActive
Expand Down
2 changes: 1 addition & 1 deletion dotnet/test/common/BiDi/Script/EvaluateParametersTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public async Task CanEvaluateScriptImplicitCast()
[Test]
public async Task СanEvaluateScriptWithUserActivationTrue()
{
await context.Script.EvaluateAsync("window.open();", true, new() { UserActivation = true });
await context.Script.EvaluateAsync("window.open();", true);

var res = await context.Script.EvaluateAsync<bool>("""
navigator.userActivation.isActive && navigator.userActivation.hasBeenActive
Expand Down
3 changes: 1 addition & 2 deletions java/test/org/openqa/selenium/bidi/script/CallFunctionParameterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ void canEvaluateScriptWithUserActivationTrue() {
try (Script script = new Script(id, driver)) {

script.evaluateFunction(
new EvaluateParameters(new ContextTarget(id), "window.open();", true)
.userActivation(true));
new EvaluateParameters(new ContextTarget(id), "window.open();", false));

EvaluateResult result =
script.callFunction(
Expand Down
3 changes: 1 addition & 2 deletions java/test/org/openqa/selenium/bidi/script/EvaluateParametersTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ void canEvaluateScriptWithUserActivationTrue() {
try (Script script = new Script(id, driver)) {

script.evaluateFunction(
new EvaluateParameters(new ContextTarget(id), "window.open();", true)
.userActivation(true));
new EvaluateParameters(new ContextTarget(id), "window.open();", false));

EvaluateResult result =
script.evaluateFunction(
Expand Down
33 changes: 19 additions & 14 deletions javascript/node/selenium-webdriver/test/bidi/browsingcontext_inspector_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,24 +141,29 @@ suite(
},
)

it('can listen to fragment navigated event', async function () {
let navigationInfo = null
const browsingConextInspector = await BrowsingContextInspector(driver)
ignore(env.browsers(Browser.EDGE, Browser.CHROME)).it(
'can listen to fragment navigated event',
async function () {
let navigationInfo = null
const browsingConextInspector = await BrowsingContextInspector(driver)

const browsingContext = await BrowsingContext(driver, {
browsingContextId: await driver.getWindowHandle(),
})
await browsingContext.navigate(Pages.linkedImage, 'complete')
const browsingContext = await BrowsingContext(driver, {
browsingContextId: await driver.getWindowHandle(),
})
await browsingContext.navigate(Pages.linkedImage, 'complete')

await browsingConextInspector.onFragmentNavigated((entry) => {
navigationInfo = entry
})
await browsingConextInspector.onFragmentNavigated((entry) => {
navigationInfo = entry
})

await browsingContext.navigate(Pages.linkedImage + '#linkToAnchorOnThisPage', 'complete')
await browsingContext.navigate(Pages.linkedImage + '#linkToAnchorOnThisPage', 'complete')

assert.equal(navigationInfo.browsingContextId, browsingContext.id)
assert(navigationInfo.url.includes('linkToAnchorOnThisPage'))
})
// Chrome/Edge do not return the window's browsing context id as per the spec.
// This assertion fails.
assert.equal(navigationInfo.browsingContextId, browsingContext.id)
assert(navigationInfo.url.includes('linkToAnchorOnThisPage'))
},
)

ignore(env.browsers(Browser.EDGE, Browser.CHROME)).it(
'can listen to user prompt opened event',
Expand Down
Loading