Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js][bidi]: implement permissions module commands in JS #15304

Merged
merged 20 commits into from
Mar 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7f87a48
implement BiDi permission module for JS
navin772 Feb 19, 2025
e8662de
add tests for permission module
navin772 Feb 19, 2025
f785128
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Feb 20, 2025
f516bf5
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Feb 24, 2025
f7f0d9d
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Feb 28, 2025
c9d4b42
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 5, 2025
3607c91
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 5, 2025
5b6ba96
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 5, 2025
12a6ca3
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 12, 2025
58e6c9a
ignore chrome browser tests
navin772 Mar 12, 2025
2ab68ff
modify test as per chrome default permissions
navin772 Mar 13, 2025
d4f9580
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 13, 2025
30ae690
run `format.sh`
navin772 Mar 13, 2025
d15c29b
remove initial permission assertions as it is different for browsers/…
navin772 Mar 14, 2025
0c2c433
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 17, 2025
b40904d
move `permissions.js` to `external/` dir
navin772 Mar 17, 2025
493b7f3
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 18, 2025
5fd3808
Merge branch 'trunk' into js-bidi-permissions-module
pujagani Mar 19, 2025
3f0bcae
Merge branch 'trunk' into js-bidi-permissions-module
navin772 Mar 19, 2025
63169c2
Merge branch 'trunk' into js-bidi-permissions-module
harsha509 Mar 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions javascript/node/selenium-webdriver/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ js_library(
"devtools/*.js",
"common/*.js",
"bidi/*.js",
"bidi/external/*.js",
]),
deps = [
":node_modules/@bazel/runfiles",
Expand Down
73 changes: 73 additions & 0 deletions javascript/node/selenium-webdriver/bidi/external/permissions.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
// Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

const PermissionState = Object.freeze({
GRANTED: 'granted',
DENIED: 'denied',
PROMPT: 'prompt',
})

class Permission {
constructor(driver) {
this._driver = driver
}

async init() {
if (!(await this._driver.getCapabilities()).get('webSocketUrl')) {
throw Error('WebDriver instance must support BiDi protocol')
}

this.bidi = await this._driver.getBidi()
}

/**
* Sets a permission state for a given permission descriptor.
* @param {Object} permissionDescriptor The permission descriptor.
* @param {string} state The permission state (granted, denied, prompt).
* @param {string} origin The origin for which the permission is set.
* @param {string} [userContext] The user context id (optional).
* @returns {Promise<void>}
*/
async setPermission(permissionDescriptor, state, origin, userContext = null) {
if (!Object.values(PermissionState).includes(state)) {
throw new Error(`Invalid permission state. Must be one of: ${Object.values(PermissionState).join(', ')}`)
}

const command = {
method: 'permissions.setPermission',
params: {
descriptor: permissionDescriptor,
state: state,
origin: origin,
},
}

if (userContext) {
command.params.userContext = userContext
}

await this.bidi.send(command)
}
}

async function getPermissionInstance(driver) {
let instance = new Permission(driver)
await instance.init()
return instance
}

module.exports = { getPermissionInstance, PermissionState }
147 changes: 147 additions & 0 deletions javascript/node/selenium-webdriver/test/bidi/permissions_test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,147 @@
// Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

'use strict'

const assert = require('node:assert')
const { Pages, suite } = require('../../lib/test')
const { Browser } = require('selenium-webdriver')
const BrowserBiDi = require('selenium-webdriver/bidi/browser')
const getScriptManager = require('selenium-webdriver/bidi/scriptManager')
const { getPermissionInstance, PermissionState } = require('selenium-webdriver/bidi/external/permissions')
const BrowsingContext = require('selenium-webdriver/bidi/browsingContext')
const { CreateContextParameters } = require('selenium-webdriver/bidi/createContextParameters')

suite(
function (env) {
describe('BiDi Permissions', function () {
let driver, permission, browser, script

const GET_GEOLOCATION_PERMISSION =
"async () => { const perm = await navigator.permissions.query({ name: 'geolocation' }); return perm.state; }"
const GET_ORIGIN = '() => {return window.location.origin;}'

beforeEach(async function () {
driver = await env.builder().build()
permission = await getPermissionInstance(driver)
browser = await BrowserBiDi(driver)
script = await getScriptManager([], driver)
})

afterEach(function () {
return driver.quit()
})

it('can set permission to granted', async function () {
const context = await BrowsingContext(driver, { type: 'tab' })
await context.navigate(Pages.blankPage, 'complete')

const origin = await script.callFunctionInBrowsingContext(context.id, GET_ORIGIN, true, [])
const originValue = origin.result.value

await permission.setPermission({ name: 'geolocation' }, PermissionState.GRANTED, originValue)

const result = await script.callFunctionInBrowsingContext(context.id, GET_GEOLOCATION_PERMISSION, true, [])
assert.strictEqual(result.result.value, PermissionState.GRANTED)
})

it('can set permission to denied', async function () {
const context = await BrowsingContext(driver, { type: 'tab' })
await context.navigate(Pages.blankPage, 'complete')

const origin = await script.callFunctionInBrowsingContext(context.id, GET_ORIGIN, true, [])

const originValue = origin.result.value
await permission.setPermission({ name: 'geolocation' }, PermissionState.DENIED, originValue)

const result = await script.callFunctionInBrowsingContext(context.id, GET_GEOLOCATION_PERMISSION, true, [])
assert.strictEqual(result.result.value, PermissionState.DENIED)
})

it('can set permission to prompt', async function () {
const context = await BrowsingContext(driver, { type: 'tab' })
await context.navigate(Pages.blankPage, 'complete')

const origin = await script.callFunctionInBrowsingContext(context.id, GET_ORIGIN, true, [])

const originValue = origin.result.value
await permission.setPermission({ name: 'geolocation' }, PermissionState.DENIED, originValue)

await permission.setPermission({ name: 'geolocation' }, PermissionState.PROMPT, originValue)

const result = await script.callFunctionInBrowsingContext(context.id, GET_GEOLOCATION_PERMISSION, true, [])
assert.strictEqual(result.result.value, PermissionState.PROMPT)
})

it('can set permission for a user context', async function () {
const userContext = await browser.createUserContext()

const context1 = await BrowsingContext(driver, { type: 'tab' })
const context2 = await BrowsingContext(driver, {
type: 'tab',
createParameters: new CreateContextParameters().userContext(userContext),
})

await context1.navigate(Pages.blankPage, 'complete')
await context2.navigate(Pages.blankPage, 'complete')

const origin = await script.callFunctionInBrowsingContext(context1.id, GET_ORIGIN, true, [])
const originValue = origin.result.value

// Get the actual permission states from each context
const originalTabPermission = await script.callFunctionInBrowsingContext(
context1.id,
GET_GEOLOCATION_PERMISSION,
true,
[],
)

const newTabPermission = await script.callFunctionInBrowsingContext(
context2.id,
GET_GEOLOCATION_PERMISSION,
true,
[],
)

const originalTabState = originalTabPermission.result.value
const newTabState = newTabPermission.result.value

// Set permission only for the user context
await permission.setPermission({ name: 'geolocation' }, PermissionState.GRANTED, originValue, userContext)

// Check that the original tab's permission state hasn't changed
const originalTabUpdatedPermission = await script.callFunctionInBrowsingContext(
context1.id,
GET_GEOLOCATION_PERMISSION,
true,
[],
)
assert.strictEqual(originalTabUpdatedPermission.result.value, originalTabState)

// Check that the new tab's permission state has been updated to GRANTED
const newTabUpdatedPermission = await script.callFunctionInBrowsingContext(
context2.id,
GET_GEOLOCATION_PERMISSION,
true,
[],
)
assert.strictEqual(newTabUpdatedPermission.result.value, PermissionState.GRANTED)
})
})
},
{ browsers: [Browser.FIREFOX, Browser.CHROME, Browser.EDGE] },
)