Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Revisit ignored intergration tests for chrome/edge #15324

Merged
merged 18 commits into from
Feb 24, 2025
Merged

[dotnet] Revisit ignored intergration tests for chrome/edge #15324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2a06865
TextInputShouldNotClearWhenDisabled
nvborisenko Feb 22, 2025
07e2e95
TextAreaShouldNotClearWhenDisabled
nvborisenko Feb 22, 2025
3899764
ShouldBeAbleToTypeIntoContentEditableElementWithExistingValue
nvborisenko Feb 22, 2025
b3d24a0
ShouldAppendToTinyMCE
nvborisenko Feb 22, 2025
cc5609f
AppendsTextToEndOfContentEditableWithMultipleTextNodes
nvborisenko Feb 22, 2025
ab4625e
GetCookiesInAFrame
nvborisenko Feb 22, 2025
d8c392f
ShouldThrowInvalidSelectorExceptionWhenXPathReturnsWrongType
nvborisenko Feb 22, 2025
2ef4e7a
ShouldBeAbleToReturnArraysOfWebElementsFromAsyncScripts
nvborisenko Feb 22, 2025
c30f5a5
ShouldWaitForLoadsToCompleteAfterJavascriptCausesANewPageToLoad
nvborisenko Feb 22, 2025
f73968c
ShouldBeAbleToFindElementAfterJavascriptCausesANewPageToLoad
nvborisenko Feb 22, 2025
935e53c
ClickOnSvgElement
nvborisenko Feb 22, 2025
a0b8561
ClickFileInput
nvborisenko Feb 22, 2025
f4e4da5
ShouldAllowUsersToHoverOverElements
nvborisenko Feb 22, 2025
94e0ed0
Merge remote-tracking branch 'upstream/trunk' into dotnet-revisit-ign…
nvborisenko Feb 22, 2025
dd5fe53
Isolation issue?
nvborisenko Feb 23, 2025
b6c87a1
Revert "Isolation issue?" Yes, it is, skipping.
nvborisenko Feb 23, 2025
1fd0133
Revert "ShouldBeAbleToFindElementAfterJavascriptCausesANewPageToLoad"
nvborisenko Feb 23, 2025
588f99b
Revert "ShouldWaitForLoadsToCompleteAfterJavascriptCausesANewPageToLoad"
nvborisenko Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions dotnet/test/common/ClearTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ public void WritableTextInputShouldClear()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void TextInputShouldNotClearWhenDisabled()
{
driver.Url = readOnlyPage;
Expand Down Expand Up @@ -67,8 +65,6 @@ public void WritableTextAreaShouldClear()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void TextAreaShouldNotClearWhenDisabled()
{
driver.Url = readOnlyPage;
Expand Down
6 changes: 0 additions & 6 deletions dotnet/test/common/ContentEditableTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ public void ShouldBeAbleToTypeIntoEmptyContentEditableElement()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.Edge, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.Firefox, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.Safari, "Driver prepends text to contentEditable areas")]
public void ShouldBeAbleToTypeIntoContentEditableElementWithExistingValue()
Expand Down Expand Up @@ -108,8 +106,6 @@ public void ShouldBeAbleToTypeIntoTinyMCE()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.Edge, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.Firefox, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.IE, "Prepends text")]
[IgnoreBrowser(Browser.Safari, "Driver prepends text to contentEditable areas")]
Expand All @@ -127,8 +123,6 @@ public void ShouldAppendToTinyMCE()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.Edge, "Driver prepends text in contentEditable areas")]
[IgnoreBrowser(Browser.Firefox, "Browser does not automatically focus body element in frame")]
[IgnoreBrowser(Browser.Safari, "Driver prepends text to contentEditable areas")]
public void AppendsTextToEndOfContentEditableWithMultipleTextNodes()
Expand Down
2 changes: 0 additions & 2 deletions dotnet/test/common/CookieImplementationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,6 @@ public void AddCookiesWithDifferentPathsThatAreRelatedToOurs()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Chrome does not retrieve cookies when in frame.")]
[IgnoreBrowser(Browser.Edge, "Edge does not retrieve cookies when in frame.")]
[IgnoreBrowser(Browser.Firefox, "https://github.com/mozilla/geckodriver/issues/1104")]
public void GetCookiesInAFrame()
{
Expand Down
16 changes: 0 additions & 16 deletions dotnet/test/common/ElementFindingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,17 +457,13 @@ public void ShouldThrowAnExceptionWhenThereIsNoLinkToClick()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathIsSyntacticallyInvalidInDriverFindElement()
{
driver.Url = formsPage;
Assert.That(() => driver.FindElement(By.XPath("this][isnot][valid")), Throws.InstanceOf<InvalidSelectorException>());
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathIsSyntacticallyInvalidInDriverFindElements()
{
if (TestUtilities.IsIE6(driver))
Expand All @@ -481,8 +477,6 @@ public void ShouldThrowInvalidSelectorExceptionWhenXPathIsSyntacticallyInvalidIn
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathIsSyntacticallyInvalidInElementFindElement()
{
driver.Url = formsPage;
Expand All @@ -491,8 +485,6 @@ public void ShouldThrowInvalidSelectorExceptionWhenXPathIsSyntacticallyInvalidIn
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathIsSyntacticallyInvalidInElementFindElements()
{
driver.Url = formsPage;
Expand All @@ -501,17 +493,13 @@ public void ShouldThrowInvalidSelectorExceptionWhenXPathIsSyntacticallyInvalidIn
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathReturnsWrongTypeInDriverFindElement()
{
driver.Url = formsPage;
Assert.That(() => driver.FindElement(By.XPath("count(//input)")), Throws.InstanceOf<InvalidSelectorException>());
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathReturnsWrongTypeInDriverFindElements()
{
if (TestUtilities.IsIE6(driver))
Expand All @@ -525,8 +513,6 @@ public void ShouldThrowInvalidSelectorExceptionWhenXPathReturnsWrongTypeInDriver
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathReturnsWrongTypeInElementFindElement()
{
driver.Url = formsPage;
Expand All @@ -536,8 +522,6 @@ public void ShouldThrowInvalidSelectorExceptionWhenXPathReturnsWrongTypeInElemen
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
[IgnoreBrowser(Browser.Edge, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743")]
public void ShouldThrowInvalidSelectorExceptionWhenXPathReturnsWrongTypeInElementFindElements()
{
if (TestUtilities.IsIE6(driver))
Expand Down
1 change: 0 additions & 1 deletion dotnet/test/common/ExecutingAsyncJavascriptTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ public void ShouldBeAbleToReturnWebElementsFromAsyncScripts()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4525")]
public void ShouldBeAbleToReturnArraysOfWebElementsFromAsyncScripts()
{
driver.Url = ajaxyPage;
Expand Down
4 changes: 0 additions & 4 deletions dotnet/test/common/Interactions/BasicMouseInterfaceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,10 +280,6 @@ public void ShouldAllowUsersToHoverOverElements()
driver.Url = javascriptPage;

IWebElement element = driver.FindElement(By.Id("menu1"));
if (!Platform.CurrentPlatform.IsPlatformType(PlatformType.Windows))
{
Assert.Ignore("Skipping test: Simulating hover needs native events");
}

IWebElement item = driver.FindElement(By.Id("item1"));
Assert.That(item.Text, Is.EqualTo(""));
Expand Down
2 changes: 0 additions & 2 deletions dotnet/test/common/SvgDocumentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ public class SvgDocumentTest : DriverTestFixture
{
[Test]
[IgnoreBrowser(Browser.IE, "IE driver in Edge does not support clicking on SVG element")]
[IgnoreBrowser(Browser.Chrome, "Chrome driver does not support clicking on SVG element yet")]
[IgnoreBrowser(Browser.Edge, "Edge driver does not support clicking on SVG element yet")]
public void ClickOnSvgElement()
{
if (TestUtilities.IsOldIE(driver))
Expand Down
2 changes: 0 additions & 2 deletions dotnet/test/common/UploadTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,6 @@ public void CleanFileInput()
}

[Test]
[IgnoreBrowser(Browser.Chrome, "Chrome driver does not throw exception.")]
[IgnoreBrowser(Browser.Edge, "Edge driver does not throw exception.")]
public void ClickFileInput()
{
driver.Url = uploadPage;
Expand Down