[grid] Introduced new variable for server start timeout

[FloKNetcare]

User description

Added a new variable in DockerSessionFactory that can be used as a maximum to wait for the server/node to start. Made it adjustable via a DockerFlag and set the default to 60 seconds, which was previously the hardcoded value in that field.

Also added a line to Dockerfile in dev-image, because dev container was not working as is.

Fixes #1 (I apologize, I thought the total number of issues fixed was meant here, not the exact number to identify the issue that was fixed)

Motivation and Context

We encountered a problem that our node wasn't ready by the time it was given to start up (1 Minute in the current version of the code and not adjustable). So we wanted to make it adjustable and see if the node starts up if given more time. We already have built the jar with the changes and were able to set up the server start timeout successfully (and the node actually started up successfully to after about 90 seconds).

We also saw that the dev container is not able to start up as it is right now, we added a line in the dev-image/Dockerfile to fix it.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation. (Not really sure if this is done automatically, but if not the flag probably needs to be added to https://www.selenium.dev/documentation/grid/configuration/cli_options/#docker )
• I have updated the documentation accordingly. (Again: not sure if the changes include that, from what I understand.)
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Bug fix, Enhancement

---

Description

• Introduced a configurable server start timeout in DockerSessionFactory.

• Added a new DockerFlag for server start timeout configuration.

• Updated dev-image Dockerfile to fix container startup issues.

• Adjusted default server start timeout to 60 seconds.

---

Changes walkthrough 📝

	Relevant files
Enhancement	DockerFlags.java Introduced server start timeout flag                                          java/src/org/openqa/selenium/grid/node/docker/DockerFlags.java Added a new parameter --docker-server-start-timeout. Configured the parameter to set a maximum server start time. +6/-0      DockerOptions.java Added server start timeout configuration                                  java/src/org/openqa/selenium/grid/node/docker/DockerOptions.java Added a default server start timeout constant. Implemented a method to fetch server start timeout from configuration. Integrated server start timeout into Docker session factory creation. +7/-0      DockerSessionFactory.java Integrated server start timeout in session factory              java/src/org/openqa/selenium/grid/node/docker/DockerSessionFactory.java Added a new serverStartTimeout field. Updated constructor to accept server start timeout. Replaced hardcoded timeout with configurable timeout in server start logic. +5/-2
Bug fix	Dockerfile Fixed dev container startup issues                                              scripts/dev-image/Dockerfile Removed problematic Google Chrome sources list. Ensured dev container can start without errors. +1/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Parameter Validation The new server start timeout parameter lacks minimum/maximum value validation. Should consider adding bounds to prevent unreasonable timeout values. @Parameter( names = {"--docker-server-start-timeout"}, description = "Max time (in seconds) to wait for the server to successfully start up, before cancelling the process.") @ConfigValue(section = DockerOptions.DOCKER_SECTION, name = "server-start-timeout", example = "55") private Integer serverStartTimeout; Error Handling The TimeoutException catch block should include more detailed error information about the timeout duration that was exceeded. waitForServerToStart(client, serverStartTimeout); } catch (TimeoutException e) { span.setAttribute(AttributeKey.ERROR.getKey(), true); span.setStatus(Status.CANCELLED);

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Add timeout value validation Add validation for the server start timeout value to ensure it's positive and within reasonable bounds (e.g., between 1 and 300 seconds) to prevent operational issues. java/src/org/openqa/selenium/grid/node/docker/DockerFlags.java [57-61] @Parameter( names = {"--docker-server-start-timeout"}, - description = "Max time (in seconds) to wait for the server to successfully start up, before cancelling the process.") + description = "Max time (in seconds) to wait for the server to successfully start up, before cancelling the process. Value must be between 1 and 300.") @ConfigValue(section = DockerOptions.DOCKER_SECTION, name = "server-start-timeout", example = "55") +@Min(1) +@Max(300) private Integer serverStartTimeout; Apply this suggestion Suggestion importance[1-10]: 7 __ Why: Adding validation constraints for the timeout value is important to prevent operational issues from invalid inputs. The suggestion properly uses Java validation annotations to enforce reasonable bounds.	Medium
	Add null safety check Add null check for the server start timeout configuration to prevent potential NullPointerException when converting to Duration. java/src/org/openqa/selenium/grid/node/docker/DockerOptions.java [109-111] private Duration getServerStartTimeout() { - return Duration.ofSeconds(config.getInt(DOCKER_SECTION, "server-start-timeout").orElse(DEFAULT_SERVER_START_TIMEOUT)); + Integer timeout = config.getInt(DOCKER_SECTION, "server-start-timeout").orElse(DEFAULT_SERVER_START_TIMEOUT); + return timeout != null ? Duration.ofSeconds(timeout) : Duration.ofSeconds(DEFAULT_SERVER_START_TIMEOUT); } Apply this suggestion Suggestion importance[1-10]: 3 __ Why: The suggestion is technically correct but unnecessary since Optional.orElse() already handles null cases safely, making the additional null check redundant.	Low
Update

[diemol]

Please run ./scripts/format.sh to fix the linting issues.

[VietND96]

Thank you, @FloKNetcare!