Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] Annotate nullability on WebDriver.SessionId #15350

Merged
merged 1 commit into from
Feb 28, 2025
Merged

[dotnet] Annotate nullability on WebDriver.SessionId #15350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dotnet/src/webdriver/IHasSessionId.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
// under the License.
// </copyright>

#nullable enable

namespace OpenQA.Selenium
{
/// <summary>
Expand Down
10 changes: 3 additions & 7 deletions dotnet/src/webdriver/WebDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,13 @@ public ReadOnlyCollection<string> WindowHandles
/// </summary>
public bool IsActionExecutor => true;

#nullable enable

/// <summary>
/// Gets the <see cref="SessionId"/> for the current session of this driver.
/// Gets the <see cref="Selenium.SessionId"/> for the current session of this driver.
/// </summary>
public SessionId SessionId { get; private set; }

#nullable enable

/// <summary>
/// Gets or sets the <see cref="IFileDetector"/> responsible for detecting
/// sequences of keystrokes representing file paths and names.
Expand Down Expand Up @@ -715,8 +715,6 @@ protected bool RegisterInternalDriverCommand(string commandName, [NotNullWhen(tr
return this.RegisterDriverCommand(commandName, commandInfo, true);
}

#nullable restore

/// <summary>
/// Stops the client from running
/// </summary>
Expand Down Expand Up @@ -747,8 +745,6 @@ protected virtual void Dispose(bool disposing)
this.CommandExecutor.Dispose();
}

#nullable enable

private static void UnpackAndThrowOnError(Response errorResponse, string commandToExecute)
{
// Check the status code of the error, and only handle if not success.
Expand Down