-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rb][BiDi] Add Browser context activate command #15365
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good test. I'm guessing in reality this is bringing the window up into focus and loading the about:blank or equivalent page? (i've not seen this bidi command before).
Yes exactly |
Add activate method to browser context
User description
Motivation and Context
This change is added to add full support for the BiDi protocol for our Ruby bindings
For more documentation regarding the activate command:
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Added
activate
method toBrowsingContext
for BiDi protocol support.Implemented integration test for
activate
method inBrowsingContext
.Updated type signature for
activate
method inBrowsingContext
RBS file.Changes walkthrough 📝
browsing_context.rb
Add `activate` method to `BrowsingContext` class
rb/lib/selenium/webdriver/bidi/browsing_context.rb
activate
method toBrowsingContext
class.browsingContext.activate
command with context ID.browsing_context.rbs
Update type signature for `activate` method
rb/sig/lib/selenium/webdriver/bidi/browsing_context.rbs
activate
method.activate
method with optionalcontext_id
parameter.browsing_context_spec.rb
Add integration test for `activate` method
rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb
activate
method.document.hasFocus()
.