Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Fix code formatting selenium_manager_tests.py #15413

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

cgoldberg
Copy link
Contributor

@cgoldberg cgoldberg commented Mar 13, 2025

User description

Motivation and Context

This PR fixes a minor code formatting violation in py/test/selenium/webdriver/common/selenium_manager_tests.py that the linting tools were complaining about. All Python linting runs completely clean after this fix.

Tested locally with: tox -e linting -c ./py/tox.ini

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix


Description

  • Fixed code formatting in selenium_manager_tests.py.

  • Resolved linting issues for cleaner Python code.


Changes walkthrough 📝

Relevant files
Bug fix
selenium_manager_tests.py
Refactor mock.patch usage for better formatting                   

py/test/selenium/webdriver/common/selenium_manager_tests.py

  • Replaced nested mock.patch calls with a cleaner context manager.
  • Improved readability and compliance with linting standards.
  • +4/-3     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @cgoldberg cgoldberg merged commit 17461ce into SeleniumHQ:trunk Mar 17, 2025
    14 of 17 checks passed
    @cgoldberg cgoldberg deleted the fix-lint-violation branch March 17, 2025 01:20
    sandeepsuryaprasad pushed a commit to sandeepsuryaprasad/selenium that referenced this pull request Mar 23, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant