-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js] add ErrorCode for DetachedShadowRootError
#15455
Conversation
This reverts commit f17dd08dd32998a310510f0abc44e5b484202a4d.
This reverts commit cc16e3f. oops
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Delta456!
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Add ErrorCode for
DetachedShadowRootError
Motivation and Context
Fixes #13580
Types of changes
Checklist
PR Type
Bug fix
Description
Added a new error code
DETACHED_SHADOW_ROOT
toErrorCode
.Mapped
DETACHED_SHADOW_ROOT
toDetachedShadowRootError
in error handling.Enhanced error handling for detached shadow root scenarios.
Changes walkthrough 📝
error.js
Introduced `DETACHED_SHADOW_ROOT` error code and mapping
javascript/node/selenium-webdriver/lib/error.js
DETACHED_SHADOW_ROOT
with code 65 toErrorCode
.DETACHED_SHADOW_ROOT
toDetachedShadowRootError
inLEGACY_ERROR_CODE_TO_TYPE
.