Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CONTRIBUTING.md): update bazel commands for JS #15507

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

Delta456
Copy link
Member

@Delta456 Delta456 commented Mar 25, 2025

User description

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Updates bazel commands for JS bindings

Motivation and Context

The pre existing commands are invalid. This PR replaces them with the working ones

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Documentation, Bug fix


Description

  • Updated Bazel commands for Node tests in CONTRIBUTING.md.

  • Corrected Firefox Atom test commands to remove invalid paths.

  • Improved documentation accuracy for JS bindings testing.


Changes walkthrough 📝

Relevant files
Documentation
CONTRIBUTING.md
Correct Bazel commands for JS testing in documentation     

CONTRIBUTING.md

  • Updated Bazel command for Node tests to :all.
  • Fixed Firefox Atom test command by removing invalid paths.
  • Enhanced clarity and correctness of testing instructions.
  • +2/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Thank you @Delta456 !

    @harsha509 harsha509 merged commit 23eb86b into SeleniumHQ:trunk Mar 25, 2025
    9 checks passed
    @Delta456 Delta456 deleted the patch-1 branch March 25, 2025 11:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants