use generics for AbstractFindByBuilder to avoid excessive casting #15526
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement
Description
Refactored
AbstractFindByBuilder
to use generics for type safety.Updated
FindByBuilder
classes to leverage generics, reducing casting.Improved method signatures for better clarity and type enforcement.
Changes walkthrough 📝
AbstractFindByBuilder.java
Add generics to `AbstractFindByBuilder` for type safety
java/src/org/openqa/selenium/support/AbstractFindByBuilder.java
AbstractFindByBuilder
class.buildIt
method to use generic typeT
.FindAll.java
Refactor `FindAll.FindByBuilder` to use generics
java/src/org/openqa/selenium/support/FindAll.java
FindByBuilder
to extendAbstractFindByBuilder
withFindAll
.buildIt
method to acceptFindAll
type directly.FindBy.java
Refactor `FindBy.FindByBuilder` to use generics
java/src/org/openqa/selenium/support/FindBy.java
FindByBuilder
to extendAbstractFindByBuilder
withFindBy
.buildIt
method to acceptFindBy
type directly.FindBys.java
Refactor `FindBys.FindByBuilder` to use generics
java/src/org/openqa/selenium/support/FindBys.java
FindByBuilder
to extendAbstractFindByBuilder
withFindBys
.buildIt
method to acceptFindBys
type directly.