[java] Enable bidi support for Chrome and Firefox by default #15531
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
We need to figure out how to make this transition with limited impact on users since not all computers have socket access enabled. |
|
CDP works over WebSockets, is there any issues? |
|
Yeah, when you pass true as a capability and the remote end can't satisfy it, you can't get a session. Everything breaks and it's not obvious why. |
| @@ -66,6 +66,7 @@ public FirefoxOptions() { | |||
| // will enable it. | |||
| // https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/. | |||
| addPreference("remote.active-protocols", 3); | |||
There was a problem hiding this comment.
There was pending PR for this. Let me go sort that out. Thank you!
| @@ -66,6 +66,7 @@ public FirefoxOptions() { | |||
| // will enable it. | |||
| // https://fxdx.dev/deprecating-cdp-support-in-firefox-embracing-the-future-with-webdriver-bidi/. | |||
| addPreference("remote.active-protocols", 3); | |||
| enableBiDi(); | |||
There was a problem hiding this comment.
Would it make sense to give the user a choice to opt-out in case they really don't want to see BiDi enabled?
|
Seems we don't want to do this yet. Closing. |
PR Type
Enhancement
Description
Enabled WebDriver BiDi support by default for Chrome.
Enabled WebDriver BiDi support by default for Firefox.
Updated constructors in
ChromiumOptionsandFirefoxOptionsto includeenableBiDicalls.Changes walkthrough 📝
ChromiumOptions.java
Enable BiDi support by default in ChromiumOptionsjava/src/org/openqa/selenium/chromium/ChromiumOptions.java
enableBiDiin the constructor.browsers.
FirefoxOptions.java
Enable BiDi support by default in FirefoxOptionsjava/src/org/openqa/selenium/firefox/FirefoxOptions.java
enableBiDiin the default constructor.