[py] complete test_should_throw_an_exception_if_an_alert_has_not_been_dealt_with_and_dismiss_the_alert

[Delta456]

User description

💥 What does this PR do?

Implements alert test test_should_throw_an_exception_if_an_alert_has_not_been_dealt_with_and_dismiss_the_alert as it was marked as TODO

🔧 Implementation Notes

Uses code from other tests as inspiration

💡 Additional Considerations

🔄 Types of changes

• Bug fix (backwards compatible)

---

PR Type

Tests

---

Description

• Implemented the test test_should_throw_an_exception_if_an_alert_has_not_been_dealt_with_and_dismiss_the_alert.

• Added logic to handle and dismiss alerts in the test.

• Marked the test as expected to fail on Safari using @pytest.mark.xfail_safari.

---

Changes walkthrough 📝

	Relevant files
Tests	alerts_tests.py Added and completed alert handling test                                    py/test/selenium/webdriver/common/alerts_tests.py Completed the TODO test test_should_throw_an_exception_if_an_alert_has_not_been_dealt_with_and_dismiss_the_alert. Added logic to trigger and handle alerts using WebDriverWait and exception handling. Marked the test as expected to fail on Safari. +9/-3

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ No major issues detected

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	✅ Missing verification after alert dismissal Suggestion Impact: The commit added verification after alert dismissal, but instead of checking the page title as suggested, it verifies the alert is no longer present by trying to access alert.text which should raise NoAlertPresentException code diff: + with pytest.raises(NoAlertPresentException): + alert.text The test is missing an assertion to verify that the alert was properly dismissed. After dismissing the alert, add an assertion to confirm that the alert is no longer present and that the page is in the expected state. py/test/selenium/webdriver/common/alerts_tests.py [187-196] @pytest.mark.xfail_safari def test_should_throw_an_exception_if_an_alert_has_not_been_dealt_with_and_dismiss_the_alert(driver, pages): pages.load("alerts.html") driver.find_element(By.ID, "alert").click() WebDriverWait(driver, 5).until(EC.alert_is_present()) with pytest.raises(UnexpectedAlertPresentException): driver.find_element(By.ID, "select").click() alert = _wait_for_alert(driver) alert.dismiss() + + # Verify alert is dismissed + assert "Testing Alerts" == driver.title [Suggestion has been applied] Suggestion importance[1-10]: 7 __ Why: The suggestion correctly identifies that the test lacks verification after dismissing the alert. Adding an assertion to check the page title is a good practice to ensure the alert was properly dismissed and the page returned to its expected state.	Medium
Update

[VietND96]

LGTM, adding @titusfortner to double check.