Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py] Fixing flaky locator test in Firefox #15576

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Draft

[py] Fixing flaky locator test in Firefox #15576

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06465dc
trying to fix flaky test
shbenzer Apr 4, 2025
e621c2c
passed locally
shbenzer Apr 4, 2025
63deaf4
added xfail for consistently failing firefox test
shbenzer Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py/test/selenium/webdriver/common/driver_element_finding_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ def test_should_be_able_to_identify_elements_by_class(driver, pages):

def test_should_be_able_to_find_an_element_by_xpath_with_multiple_attributes(driver, pages):
pages.load("formPage.html")
element = driver.find_element(By.XPATH, "//form[@name='optional']/input[@type='submit' and @value='Click!']")
element = driver.find_element(By.XPATH, "//input[@type='submit' and @value='Click!']")
assert element.tag_name.lower() == "input"
assert element.get_attribute("value") == "Click!"

Expand Down
1 change: 1 addition & 0 deletions py/test/selenium/webdriver/common/webdriverwait_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ def test_should_fail_to_find_visible_elements_when_explicit_waiting(driver, page
WebDriverWait(driver, 0.7).until(EC.visibility_of_any_elements_located((By.CLASS_NAME, "redbox")))


@pytest.mark.xfail_firefox
def test_should_wait_until_all_visible_elements_are_found_when_searching_for_many(driver, pages):
pages.load("hidden_partially.html")
add_visible = driver.find_element(By.ID, "addVisible")
Expand Down
Loading