-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[py] Skip bidi tests on browsers that don't support bidi #15625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Can we have a common marker for Safari, WebKitGTK and WPEWebKit apart from their individual ones which we can use to skip tests? IMO, using that many xfail marker makes the test look not so elegant. |
I can create one like |
@navin772 check out these changes... I updated the PR description also. Now you don't need to use |
This looks much better, can you also add a note in the testing guide for the same? It will help contributors understand which drivers are being skipped. |
@navin772 Which testing guide do you mean? In the main
I am going to merge this PR, but I will update any documentation that you think this should be mentioned in. |
User description
💥 What does this PR do?
This PR adjusts the internal Python PyTest configuration so tests are skipped when
--bidi
is enabled on browsers that don't support BiDi (ie
,safari
,webkitgtk
,wpewebkit
).This removes the need to mark BiDi tests with
xfail
markers on browsers where they are expected to fail.🔄 Types of changes
PR Type
Bug fix