-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[grid] Session can be deleted via Grid UI #15808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be protected under some flag because I know people will complain about having this option open without any validation.
CI Feedback 🧐A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
User description
🔗 Related Issues
Fixes #11519 - the oldest and most voted request.
💥 What does this PR do?
On Sessions view, adding a button to delete the session in the session capabilities dialog.
Assume that the user can enable basic auth to limit UI access, or disable Grid UI to prevent everyone from doing this.
Screen.Recording.2025-05-28.at.21.55.20.mp4
🔧 Implementation Notes
webSocketUrl
(a session enabled BiDi) after removing /se/ and everything after in path.webSocketUrl
, request URL will be constructed based on currentwindow.location.href
after removing /ui/ and everything after in path💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement, Tests
Description
Add session deletion feature to Grid UI
Add comprehensive tests for session deletion
Changes walkthrough 📝
RunningSessions.tsx
Implement session deletion UI and logic in RunningSessions
javascript/grid-ui/src/components/RunningSessions/RunningSessions.tsx
RunningSessions.test.tsx
Add tests for session deletion UI and logic
javascript/grid-ui/src/tests/components/RunningSessions.test.tsx
feedback