Ignore scrollIntoView problems in SVG documents for Firefox driver #23
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the document is SVG instead of HTML the eventlistener for the unload event needs to be added to documentElement instead of body. This new function returns the corresponding element.
If the document in the view is a SVG scrolling does not make much sense and resulting errors can be safely ignored.
|
Can we please have a test to prevent future regressions |
IlyaNaumovich
added a commit
to IlyaNaumovich/selenium
that referenced
this pull request
Feb 11, 2018
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
…nown_ext_type Fix handling of unknown extension type
yiming-tang-cs
pushed a commit
to ponder-lab/selenium
that referenced
this pull request
Jan 2, 2020
Ensure, that session is resumed before sending more notifications. When fixing issue SeleniumHQ#23, an additional test should be added to ensure, that notifications during the handshake are not lost. Signed-off-by: Achim Kraus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the document in the view is a SVG scrolling does not make much
sense and resulting errors can be safely ignored.
The first commit is a already in pull request 21.
CLA signed