Travis CI: dist: xenial is now the default and sudo is deprecated #7419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default Travis distro is now xenial and the __sudo:__ tags is now deprecated because the sudo is _always_ available and there is no way to turn it off.
| @@ -1,6 +1,6 @@ | |||
| set -ex | |||
|
|
|||
| sh /etc/init.d/xvfb start | |||
| # sh /etc/init.d/xvfb start | |||
There was a problem hiding this comment.
Do you mean to be commenting this out?
There was a problem hiding this comment.
Yes. services: - xvfb makes it unnecessary. See:
https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-xvfb-to-run-tests-that-require-a-gui
There was a problem hiding this comment.
So why not just delete the line?
|
Merged as 3bb5d31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default Travis distro is now xenial and the sudo: tags is now deprecated because the sudo is always available and there is no way to turn it off.
Xin the preceding checkbox, I verify that I have signed the Contributor License Agreement