refactor: removed moveto command #9116
Conversation
|
@vaibhavsingh97 That method can be removed too and then clean up the tests. |
|
@AutomatedTester thanks for the help 🙇 |
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
For this PR we were only looking at mouseMove. The other files may need tweaks where they call mouseMove
| @@ -50,115 +50,6 @@ test.suite(function (env) { | |||
| return driver.quit() | |||
| }) | |||
|
|
|||
| it('click(element)', async function () { | |||
There was a problem hiding this comment.
I am not sure that this test are related to the change
| assert.equal(await box.getAttribute('class'), 'green') | ||
| }) | ||
|
|
||
| it('click(element) clicks in center of element', async function () { |
There was a problem hiding this comment.
I am not sure that this test are related to the change
| @@ -204,16 +95,5 @@ test.suite(function (env) { | |||
|
|
|||
| assert.equal(await el.getAttribute('value'), 'foOBar') | |||
| }) | |||
|
|
|||
| it('can interact with simple form elements', async function () { | |||
There was a problem hiding this comment.
I am not sure that this test are related to the change
| @@ -1526,76 +1526,6 @@ describe('WebDriver', function () { | |||
| .then(fail, (v) => assert.strictEqual(v, e)) | |||
| }) | |||
|
|
|||
| describe('actions()', function () { | |||
There was a problem hiding this comment.
These are not related to the legacy move
|
Hi @vaibhavsingh97 , Did you get a chance to look into the above comments ? Thanks, |
Apologies I couldn't get back on time for this 😅. I have some issues with JS tests, will be fixing those first. I will try to quickly resolve this. Thanks much for understanding 🙏 🙇 |
|
Hi @vaibhavsingh97 , Thanks for the PR. As I didn't got the reply soon, so I replaced this PR is replaced with PR #9362 as removing legacy actions will also remove |
|
Closing as the changes were merged in a different PR. |
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #6809
Motivation and Context
We will be removing this legacy
movetoaction as w3c had implemented actions API which can be used to move the mouse.LEGACY_ACTION_MOUSE_MOVE.Action.Type.POINTER_MOVE, as that switch case was usingLEGACY_ACTION_MOUSE_MOVE, and we are deprecating it. As we had removedAction.Type.POINTER_MOVE, so now we don't need POINTER_MOVE as well.mouseMove.scheduleMouseAction_Types of changes
Checklist