Skip to content

Move java sources and tests into a single tree #9710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

shs96c
Copy link
Member

@shs96c shs96c commented Aug 3, 2021

This emphasizes that all the java code is inter-related. We make use
of bazel to avoid introducing Java 8 incompatible changes, and bazel's
visibility rules to ensure that generated jars only contain what they
should.

Description

Move all the java code into a single place

Motivation and Context

Because it's nice to have everything in one place.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This emphasizes that all the java code is inter-related. We make use
of bazel to avoid introducing Java 8 incompatible changes, and bazel's
visibility rules to ensure that generated jars only contain what they
should.
@codecov-commenter
Copy link

Codecov Report

Merging #9710 (32f2672) into trunk (2aea999) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk    #9710      +/-   ##
==========================================
- Coverage   44.01%   43.99%   -0.03%     
==========================================
  Files          83       83              
  Lines        5443     5441       -2     
  Branches      245      245              
==========================================
- Hits         2396     2394       -2     
  Misses       2802     2802              
  Partials      245      245              
Impacted Files Coverage Δ
py/selenium/webdriver/common/log.py 29.57% <0.00%> (-0.98%) ⬇️
py/selenium/webdriver/remote/webdriver.py 33.90% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6665715...32f2672. Read the comment docs.

@shs96c shs96c added the C-java Java Bindings label Aug 3, 2021
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small_tests and javadoc jobs are failing

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2021

@shs96c shs96c merged commit 702b3aa into SeleniumHQ:trunk Aug 3, 2021
@shs96c shs96c deleted the single-tree branch August 3, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-java Java Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants