Skip to content

Update windows.en.md #1535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Update windows.en.md #1535

merged 6 commits into from
Dec 5, 2023

Conversation

ronPy
Copy link
Contributor

@ronPy ronPy commented Nov 28, 2023

fixed sample code to open a new window or tab using ruby

Description

current sample code doesn't work, with this change user will be pointed to the right direction on how to open a new window or tab using ruby

Motivation and Context

I was trying to achieve this and following the sample code didn't work, after looking at other languages I figured it out, maybe some people won't do that I will think the feature is just not working in ruby

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

fixed sample code to open a new window or tab using ruby
Copy link

netlify bot commented Nov 28, 2023

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2da52fb

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2023

CLA assistant check
All committers have signed the CLA.

@titusfortner
Copy link
Member

Good catch, we changed the implementation of this and didn't update the documentation.
Can you update these lines in all 4 of the translation files?

(or if you are interested in being especially helpful write the code here so we can link to it in the docs? https://github.com/SeleniumHQ/seleniumhq.github.io/blob/trunk/examples/ruby/spec/interactions/windows_spec.rb)

fix documentation on how to open a new browser tab or window using ruby
@titusfortner
Copy link
Member

@ronPy please sign the CLA. Thanks.

updated docs to use sample code
Copy link
Member

@titusfortner titusfortner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for taking the extra step here!

A couple updates specific to how Hugo/Docsy need things formatted.
Also, I don't think we need to include any of the navigation things? Just the command to create the window/tab (and the assertion in the specs so when we run it in the CI we know it is working.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ronPy!

@diemol diemol merged commit 248e5cf into SeleniumHQ:trunk Dec 5, 2023
selenium-ci added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants