-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Javascript single test file execution #1663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In selenium documentation, javascript test file execution was missing. Therefore, I added that the command to run a test file for javascript in "Running Selenium File > JavaScript" section.
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Description updated to latest commit (c6d76bd)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
@CLAassistant CLA has been signed from my end. please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Sakif-Al-Faruque ,
Thank you for the PR.
I have requested for few changes, can you look into them!
Thanks!
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
Show resolved
Hide resolved
My pleasure to have your opinion. |
Hello, @harsha509 could you please check the last commits ?! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Sakif-Al-Faruque for the changes!
Congratulations on your first contribution to Selenium Docs @Sakif-Al-Faruque 🎉 🎉 🎉 ! |
* Javascript single test file execution In selenium documentation, javascript test file execution was missing. Therefore, I added that the command to run a test file for javascript in "Running Selenium File > JavaScript" section. * Small correction in examples>javascript>test>README.md * package-lock.json file has been excluded * similar changes are added to other translated files --------- Co-authored-by: Sri Harsha <[email protected]> c2299d8
Great! Thank you so much @harsha509. Your important recommendations help me to make it. |
User description
In selenium documentation, javascript test file execution was missing. Therefore, I added that the command to run a test file for javascript in Running Selenium File > JavaScript section.
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
Type
documentation, enhancement
Description
package-lock.json
file to the project structure.Changes walkthrough
README.md
Instructions for Executing a Single JavaScript Test
examples/javascript/README.md
node example_script.spec.js
) for running aspecific test script.
first_script.en.md
Documentation Update for JavaScript Test Execution
website_and_docs/content/documentation/webdriver/getting_started/first_script.en.md
include a reference to the new instructions for executing a single
JavaScript test.
package-lock.json
Addition of package-lock.json File
package-lock.json
package-lock.json
file with basic structure.