Skip to content

Update dependency rubocop to v1.63.4 #1700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 28, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) 1.63.3 -> 1.63.4 age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.63.4

Compare Source

Bug fixes
  • #​12871: Fix an error for rubocop -V when .rubocop.yml contains ERB. ([@​earlopain][])
  • #​12862: Fix a false positive for Style/RedundantLineContinuation when line continuations involve return with a return value. ([@​koic][])
  • #​12664: Fix handling of textDocument/diagnostic. ([@​muxcmux][])
  • #​12865: Fix Rails Cops, which weren't reporting any violations unless running with bundle exec. ([@​amomchilov][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

netlify bot commented Apr 28, 2024

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 530621d
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/662f5ecf175abf0008142854
😎 Deploy Preview https://deploy-preview-1700--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

CI Failure Feedback

Action: test_examples (macos-latest, nightly)

Failed stage: Run tests [❌]

Failed test name: Remote WebDriver

Failure summary:

The action failed due to repeated errors in the Remote WebDriver tests within the
remote_webdriver_spec.rb file. Specifically, the tests for "starts remotely," "uploads," and
"downloads" encountered a TypeError related to an issue with the Selenium::Server.get method. The
error message "no implicit conversion of String into Integer" suggests that an integer was expected
where a string was provided, likely in the arguments or parameters used in the method call. Despite
multiple retries, these errors persisted, leading to the failure of the action.

Relevant error logs:
1:  ##[group]Operating System
2:  macOS
...

283:  timeout_minutes: 20
284:  max_attempts: 3
285:  command: cd examples/ruby
286:  bundle exec rspec
287:  
288:  retry_wait_seconds: 10
289:  polling_interval_seconds: 1
290:  warning_on_retry: true
291:  continue_on_error: false
...

296:  PATH: /Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools
297:  JAVA_HOME: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.23-9/arm64/Contents/Home
298:  JAVA_HOME_11_ARM64: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.23-9/arm64/Contents/Home
299:  ##[endgroup]
300:  ......*...................................***************.................................******......*........*FFF........................
301:  Pending: (Failures listed here are expected and do not affect your suite's status)
302:  1) Keys copy and paste
303:  # Test guarded; https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264
304:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
...

372:  23) Chrome Driver Options sets remote capabilities
373:  # this is example code that will not execute
374:  # ./spec/drivers/options_spec.rb:37
375:  24) Chrome Driver Options sets capabilities in the pre-selenium 4 way
376:  # this is example code that will not execute
377:  # ./spec/drivers/options_spec.rb:122
378:  Failures:
379:  1) Remote WebDriver starts remotely
380:  Got 0 failures and 2 other errors:
381:  1.1) Failure/Error:
382:  Selenium::Server.get(:latest,
383:  background: true,
384:  args: %w[--selenium-manager true --enable-managed-downloads true])
385:  TypeError:
386:  no implicit conversion of String into Integer
387:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
388:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
389:  1.2) Failure/Error:
390:  Selenium::Server.get(:latest,
391:  background: true,
392:  args: %w[--selenium-manager true --enable-managed-downloads true])
393:  TypeError:
394:  no implicit conversion of String into Integer
395:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
396:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
397:  2) Remote WebDriver uploads
398:  Got 0 failures and 2 other errors:
399:  2.1) Failure/Error:
400:  Selenium::Server.get(:latest,
401:  background: true,
402:  args: %w[--selenium-manager true --enable-managed-downloads true])
403:  TypeError:
404:  no implicit conversion of String into Integer
405:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
406:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
407:  2.2) Failure/Error:
408:  Selenium::Server.get(:latest,
409:  background: true,
410:  args: %w[--selenium-manager true --enable-managed-downloads true])
411:  TypeError:
412:  no implicit conversion of String into Integer
413:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
414:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
415:  3) Remote WebDriver downloads
416:  Got 0 failures and 2 other errors:
417:  3.1) Failure/Error:
418:  Selenium::Server.get(:latest,
419:  background: true,
420:  args: %w[--selenium-manager true --enable-managed-downloads true])
421:  TypeError:
422:  no implicit conversion of String into Integer
423:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
424:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
425:  3.2) Failure/Error:
426:  Selenium::Server.get(:latest,
427:  background: true,
428:  args: %w[--selenium-manager true --enable-managed-downloads true])
429:  TypeError:
430:  no implicit conversion of String into Integer
431:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
432:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
433:  Finished in 6 minutes 20 seconds (files took 8.32 seconds to load)
434:  139 examples, 3 failures, 24 pending
435:  Failed examples:
436:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
437:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
438:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
439:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
440:  ......*...................................***************.................................******......*........*FFF........................
441:  Pending: (Failures listed here are expected and do not affect your suite's status)
442:  1) Keys copy and paste
443:  # Test guarded; https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264
444:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
...

512:  23) Chrome Driver Options sets remote capabilities
513:  # this is example code that will not execute
514:  # ./spec/drivers/options_spec.rb:37
515:  24) Chrome Driver Options sets capabilities in the pre-selenium 4 way
516:  # this is example code that will not execute
517:  # ./spec/drivers/options_spec.rb:122
518:  Failures:
519:  1) Remote WebDriver starts remotely
520:  Got 0 failures and 2 other errors:
521:  1.1) Failure/Error:
522:  Selenium::Server.get(:latest,
523:  background: true,
524:  args: %w[--selenium-manager true --enable-managed-downloads true])
525:  TypeError:
526:  no implicit conversion of String into Integer
527:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
528:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
529:  1.2) Failure/Error:
530:  Selenium::Server.get(:latest,
531:  background: true,
532:  args: %w[--selenium-manager true --enable-managed-downloads true])
533:  TypeError:
534:  no implicit conversion of String into Integer
535:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
536:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
537:  2) Remote WebDriver uploads
538:  Got 0 failures and 2 other errors:
539:  2.1) Failure/Error:
540:  Selenium::Server.get(:latest,
541:  background: true,
542:  args: %w[--selenium-manager true --enable-managed-downloads true])
543:  TypeError:
544:  no implicit conversion of String into Integer
545:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
546:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
547:  2.2) Failure/Error:
548:  Selenium::Server.get(:latest,
549:  background: true,
550:  args: %w[--selenium-manager true --enable-managed-downloads true])
551:  TypeError:
552:  no implicit conversion of String into Integer
553:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
554:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
555:  3) Remote WebDriver downloads
556:  Got 0 failures and 2 other errors:
557:  3.1) Failure/Error:
558:  Selenium::Server.get(:latest,
559:  background: true,
560:  args: %w[--selenium-manager true --enable-managed-downloads true])
561:  TypeError:
562:  no implicit conversion of String into Integer
563:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
564:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
565:  3.2) Failure/Error:
566:  Selenium::Server.get(:latest,
567:  background: true,
568:  args: %w[--selenium-manager true --enable-managed-downloads true])
569:  TypeError:
570:  no implicit conversion of String into Integer
571:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
572:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
573:  Finished in 7 minutes 56 seconds (files took 2.75 seconds to load)
574:  139 examples, 3 failures, 24 pending
575:  Failed examples:
576:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
577:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
578:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
579:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
580:  ......*...................................***************.................................******......*........*FFF........................
581:  Pending: (Failures listed here are expected and do not affect your suite's status)
582:  1) Keys copy and paste
583:  # Test guarded; https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264
584:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
...

652:  23) Chrome Driver Options sets remote capabilities
653:  # this is example code that will not execute
654:  # ./spec/drivers/options_spec.rb:37
655:  24) Chrome Driver Options sets capabilities in the pre-selenium 4 way
656:  # this is example code that will not execute
657:  # ./spec/drivers/options_spec.rb:122
658:  Failures:
659:  1) Remote WebDriver starts remotely
660:  Got 0 failures and 2 other errors:
661:  1.1) Failure/Error:
662:  Selenium::Server.get(:latest,
663:  background: true,
664:  args: %w[--selenium-manager true --enable-managed-downloads true])
665:  TypeError:
666:  no implicit conversion of String into Integer
667:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
668:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
669:  1.2) Failure/Error:
670:  Selenium::Server.get(:latest,
671:  background: true,
672:  args: %w[--selenium-manager true --enable-managed-downloads true])
673:  TypeError:
674:  no implicit conversion of String into Integer
675:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
676:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
677:  2) Remote WebDriver uploads
678:  Got 0 failures and 2 other errors:
679:  2.1) Failure/Error:
680:  Selenium::Server.get(:latest,
681:  background: true,
682:  args: %w[--selenium-manager true --enable-managed-downloads true])
683:  TypeError:
684:  no implicit conversion of String into Integer
685:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
686:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
687:  2.2) Failure/Error:
688:  Selenium::Server.get(:latest,
689:  background: true,
690:  args: %w[--selenium-manager true --enable-managed-downloads true])
691:  TypeError:
692:  no implicit conversion of String into Integer
693:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
694:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
695:  3) Remote WebDriver downloads
696:  Got 0 failures and 2 other errors:
697:  3.1) Failure/Error:
698:  Selenium::Server.get(:latest,
699:  background: true,
700:  args: %w[--selenium-manager true --enable-managed-downloads true])
701:  TypeError:
702:  no implicit conversion of String into Integer
703:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
704:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
705:  3.2) Failure/Error:
706:  Selenium::Server.get(:latest,
707:  background: true,
708:  args: %w[--selenium-manager true --enable-managed-downloads true])
709:  TypeError:
710:  no implicit conversion of String into Integer
711:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
712:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
713:  Finished in 5 minutes 29 seconds (files took 2.54 seconds to load)
714:  139 examples, 3 failures, 24 pending
715:  Failed examples:
716:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
717:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
718:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
719:  ##[error]Final attempt failed. Child_process exited with error code 1

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

@diemol diemol merged commit 453bdc2 into trunk Apr 29, 2024
12 checks passed
@diemol diemol deleted the renovate/rubocop-1.x-lockfile branch April 29, 2024 09:45
chamiz pushed a commit to chamiz/seleniumhq.github.io that referenced this pull request Apr 29, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Diego Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant