-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add permissions examples and update the log examples #1731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permissions examples and update the log examples #1731
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Description updated to latest commit (8caf46a)
|
PR Review 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aguspe !
…ite] Co-authored-by: aguspe <[email protected]> 7b6f8c2
User description
Description
This PR adds examples for permissions in Chrome using Ruby, it also updates and organizes the logs test so they are under the same describe group
Motivation and Context
The documentation must be up to date so users can find concrete examples and be aware of all the possibilities that Selenium has to offer
Right now the example looks like this:
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
permission
to check permission states in tests.Changes walkthrough 📝
chrome_spec.rb
Add and refactor tests for Chrome browser permissions and logs
examples/ruby/spec/browsers/chrome_spec.rb
permission
to check permission states.chrome.en.md
Update Ruby code block references in Chrome documentation (EN)
website_and_docs/content/documentation/webdriver/browsers/chrome.en.md
chrome.ja.md
Update Ruby code block references in Chrome documentation (JA)
website_and_docs/content/documentation/webdriver/browsers/chrome.ja.md
chrome.pt-br.md
Update Ruby code block references in Chrome documentation (PT-BR)
website_and_docs/content/documentation/webdriver/browsers/chrome.pt-br.md
chrome.zh-cn.md
Update Ruby code block references in Chrome documentation (ZH-CN)
website_and_docs/content/documentation/webdriver/browsers/chrome.zh-cn.md