You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to build web site locally, and got build errors (~35 errors):
ERROR [ja] REF_NOT_FOUND: Ref "/advanced_features": "d:\SeleniumHQ\seleniumhq.github.io\website_and_docs\content\documentation\grid\getting_started.ja.md:315:23": page not found
ERROR Failed to read Git log: access denied: "git" is not whitelisted in policy "security.exec.allow"
Probably this is because my loccal hugo version is newer than used in CI build. I use v0.134.1
Motivation and Context
Fix local build.
Types of changes
Change to the site (I have double-checked the Netlify deployment, and my changes look good)
Code example added (and I also added the example to all translated languages)
Improved translation
Added new translation (and I also added a notice to each document missing translation)
Broken Links Multiple reference links were fixed by removing leading slashes. This could potentially break existing links if not done consistently across all pages.
Replace the term "競合状態" with a more specific and easily understandable Japanese term for race conditions in browser automation
Consider using a more specific term instead of "競合状態" to describe race conditions in the context of browser automation. A term like "タイミング問題" or "同期の問題" might be more appropriate and easier to understand for Japanese readers.
Why: The suggestion improves clarity for Japanese readers by using a more specific term for race conditions, which can enhance understanding in the context of browser automation.
7
Use a more specific Chinese term for "Components" in the reference link text to improve clarity for Chinese readers
Consider using a more specific Chinese term for "Components" in the reference link text. A term like "组件配置" or "网格组件" might be more descriptive and helpful for Chinese readers.
Why: The suggestion enhances clarity by using a more descriptive term for "Components," which can help Chinese readers better understand the context.
6
Add a brief explanation of what "slots" mean in the context of Selenium Grid to improve clarity for readers
Consider adding a brief explanation of what "slots" are in the context of Selenium Grid. This can help readers who are new to Grid understand the concept better.
-It also creates one slot per available CPU for Chromium based browsers and Firefox. For Safari, only one slot is +It also creates one slot (a concurrent session capability) per available CPU for Chromium based browsers and Firefox. For Safari, only one slot is
created. Through a specific [configuration]({{< ref "configuration" >}}), it can run sessions in Docker
containers or relay commands.
Apply this suggestion
Suggestion importance[1-10]: 6
Why: The suggestion improves clarity by explaining "slots," which can help readers unfamiliar with Selenium Grid understand the concept better.
6
Add a brief description of the Configuration section's content to provide more context for readers
Consider adding a brief description of what the Configuration section covers to provide more context for the reader. This can help users decide if they need to refer to that section.
-[Configuring Components]({{< ref "configuration" >}}) section.+[Configuring Components]({{< ref "configuration" >}}) section, which covers detailed setup options for Grid components.
Apply this suggestion
Suggestion importance[1-10]: 5
Why: Adding a brief description provides additional context, helping users decide if they need to refer to the Configuration section, although it is not crucial.
5
Best practice
Sort the list of allowed executables alphabetically
Consider sorting the list of allowed executables alphabetically for better readability and easier maintenance.
Why: Sorting the list alphabetically improves readability and maintainability, making it easier to locate specific entries and manage the list in the future.
7
Maintainability
Use relative links for internal documentation references instead of Hugo shortcodes
Consider using a relative link instead of the Hugo shortcode for internal documentation references. This can improve maintainability and make the content more portable.
-No núcleo do Selenium está [WebDriver]({{< ref "webdriver.md" >}}),+No núcleo do Selenium está [WebDriver](./webdriver),
Apply this suggestion
Suggestion importance[1-10]: 5
Why: While using relative links can improve portability, the current use of Hugo shortcodes is a common practice in Hugo-based sites for managing internal links, and changing them might not be necessary unless there's a specific reason to do so.
5
Replace Hugo shortcode with a relative link for internal documentation reference
Similar to the previous suggestion, consider using a relative link instead of the Hugo shortcode for internal documentation references to improve maintainability and portability.
-sua [Grid de navegadores]({{< ref "grid.md" >}})+sua [Grid de navegadores](../grid)
Apply this suggestion
Suggestion importance[1-10]: 5
Why: Similar to the previous suggestion, using relative links can enhance portability, but the existing Hugo shortcode is standard for Hugo sites, and changing it might not be needed unless there's a specific requirement.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
I tried to build web site locally, and got build errors (~35 errors):
Probably this is because my loccal hugo version is newer than used in CI build. I use v0.134.1
Motivation and Context
Fix local build.
Types of changes
Checklist
PR Type
documentation, configuration changes
Description
git
as an executable, resolving build issues related to Git log access.Changes walkthrough 📝
21 files
_index.ja.md
Fix reference links in Japanese documentation index
website_and_docs/content/documentation/_index.ja.md
_index.pt-br.md
Correct reference links in Portuguese documentation index
website_and_docs/content/documentation/_index.pt-br.md
_index.zh-cn.md
Update reference links in Chinese documentation index
website_and_docs/content/documentation/_index.zh-cn.md
components.en.md
Fix configuration link in English grid components documentation
website_and_docs/content/documentation/grid/components.en.md
components.ja.md
Correct configuration link in Japanese grid components documentation
website_and_docs/content/documentation/grid/components.ja.md
components.pt-br.md
Fix configuration link in Portuguese grid components documentation
website_and_docs/content/documentation/grid/components.pt-br.md
components.zh-cn.md
Update configuration link in Chinese grid components documentation
website_and_docs/content/documentation/grid/components.zh-cn.md
getting_started.en.md
Fix reference links in English grid getting started documentation
website_and_docs/content/documentation/grid/getting_started.en.md
getting_started.ja.md
Correct reference links in Japanese grid getting started documentation
website_and_docs/content/documentation/grid/getting_started.ja.md
getting_started.pt-br.md
Fix reference links in Portuguese grid getting started documentation
website_and_docs/content/documentation/grid/getting_started.pt-br.md
getting_started.zh-cn.md
Update reference links in Chinese grid getting started documentation
website_and_docs/content/documentation/grid/getting_started.zh-cn.md
_index.ja.md
Fix reference links in Japanese overview documentation
website_and_docs/content/documentation/overview/_index.ja.md
_index.pt-br.md
Correct reference links in Portuguese overview documentation
website_and_docs/content/documentation/overview/_index.pt-br.md
slashes.
_index.zh-cn.md
Update reference links in Chinese overview documentation
website_and_docs/content/documentation/overview/_index.zh-cn.md
slashes.
details.ja.md
Fix Grid reference link in Japanese overview details
website_and_docs/content/documentation/overview/details.ja.md
details.pt-br.md
Correct Grid reference link in Portuguese overview details
website_and_docs/content/documentation/overview/details.pt-br.md
details.zh-cn.md
Update Grid reference link in Chinese overview details
website_and_docs/content/documentation/overview/details.zh-cn.md
overview.en.md
Fix reference links in English test practices overview
website_and_docs/content/documentation/test_practices/overview.en.md
removing leading slashes.
overview.ja.md
Correct reference links in Japanese test practices overview
website_and_docs/content/documentation/test_practices/overview.ja.md
removing leading slashes.
overview.pt-br.md
Fix reference links in Portuguese test practices overview
website_and_docs/content/documentation/test_practices/overview.pt-br.md
removing leading slashes.
overview.zh-cn.md
Update reference links in Chinese test practices overview
website_and_docs/content/documentation/test_practices/overview.zh-cn.md
removing leading slashes.
1 files
hugo.toml
Allow `git` in Hugo security configuration
website_and_docs/hugo.toml
git
to the list of allowed executables in the securityconfiguration.