-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[java] move samesite cookie code to file #2132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Sri Harsha <[email protected]> 17c6ff9
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Moved samesite cookie code to file
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Documentation
Description
Added a new test for SameSite cookie handling in Java.
Moved SameSite cookie example code to a dedicated file.
Updated documentation to reference the new example file.
Simplified Java code snippets in multiple language-specific docs.
Changes walkthrough 📝
CookiesTest.java
Add SameSite cookie handling test in Java
examples/java/src/test/java/dev/selenium/interactions/CookiesTest.java
sameSiteCookie
.cookies.en.md
Update English docs to reference SameSite cookie example
website_and_docs/content/documentation/webdriver/interactions/cookies.en.md
cookies.ja.md
Update Japanese docs to reference SameSite cookie example
website_and_docs/content/documentation/webdriver/interactions/cookies.ja.md
cookies.pt-br.md
Update Portuguese docs to reference SameSite cookie example
website_and_docs/content/documentation/webdriver/interactions/cookies.pt-br.md
cookies.zh-cn.md
Update Chinese docs to reference SameSite cookie example
website_and_docs/content/documentation/webdriver/interactions/cookies.zh-cn.md